From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator
Date: Thu, 13 Jun 2019 16:04:40 +0200 [thread overview]
Message-ID: <450356ef-c10b-f42d-1050-7084b06abe8f@redhat.com> (raw)
In-Reply-To: <467c5374-34e6-c8d4-26c1-246f5cf31ec6@ozlabs.ru>
On 13/06/19 07:07, Alexey Kardashevskiy wrote:
> + if (as == &address_space_memory) {
> + system_as = true;
> + }
> }
Ah no, wait... On x86, there are two KVM address spaces, so you have to
pass "as" to has_memory. To detect KVM address spaces, you can allocate
an array with kvm_check_extension(kvm, KVM_CAP_MULTI_ADDRESS_SPACE)
elements (default 1 if the capability is not available), and fill it in
kvm_memory_listener_register. Then you an search for the address space
in that array, it's very small and cheap.
Promise to merge quickly with that change.
Thanks,
Paolo
prev parent reply other threads:[~2019-06-13 15:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 2:58 [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator Alexey Kardashevskiy
2018-12-14 11:07 ` Philippe Mathieu-Daudé
2018-12-17 1:27 ` Alexey Kardashevskiy
2018-12-17 12:47 ` Philippe Mathieu-Daudé
2018-12-18 0:58 ` Alexey Kardashevskiy
2019-01-03 17:37 ` Dr. David Alan Gilbert
2019-01-14 1:43 ` Alexey Kardashevskiy
2019-01-29 2:30 ` Alexey Kardashevskiy
2019-02-07 5:20 ` Alexey Kardashevskiy
2019-02-07 11:49 ` Dr. David Alan Gilbert
2019-02-08 17:26 ` Paolo Bonzini
2019-02-11 4:56 ` Alexey Kardashevskiy
[not found] ` <f346fdcb-1849-3397-7f4c-2d6ee07fcd7c@ozlabs.ru>
2019-04-24 5:32 ` Alexey Kardashevskiy
2019-04-24 5:32 ` Alexey Kardashevskiy
2019-05-21 6:37 ` Alexey Kardashevskiy
2019-06-13 5:07 ` Alexey Kardashevskiy
2019-06-13 11:49 ` Dr. David Alan Gilbert
2019-06-13 13:59 ` Paolo Bonzini
2019-06-13 14:04 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450356ef-c10b-f42d-1050-7084b06abe8f@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=danielhb413@gmail.com \
--cc=dgilbert@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).