From: Amaury Pouly <amaury.pouly@lowrisc.org>
To: thuth@redhat.com
Cc: berrange@redhat.com, marcandre.lureau@redhat.com,
mhartmay@linux.ibm.com, pbonzini@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH] chardev/char-pty: Avoid losing bytes when the other side just (re-)connected
Date: Wed, 23 Aug 2023 10:44:54 +0100 [thread overview]
Message-ID: <4505709.LvFx2qVVIh@jamesbond> (raw)
In-Reply-To: <20230816210743.1319018-1-thuth@redhat.com>
>> When starting a guest via libvirt with "virsh start --console ...",
>> the first second of the console output is missing. This is especially
>> annoying on s390x that only has a text console by default and no graphical
>> output - if the bios fails to boot here, the information about what went
>> wrong is completely lost.
Hi, we recently ran into this problem in a different scenario where we
manually invoke QEMU and connect to the PTY before starting the machine.
With the existing code, we have to add a one second delay before starting just
to make sure that we capture the early boot message. We are now running a
patched version of QEMU with pretty much the same change as yours and it seems
to work well. We are very interested in seeing this change, or a variant
thereof merged.
next prev parent reply other threads:[~2023-08-23 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 21:07 [PATCH] chardev/char-pty: Avoid losing bytes when the other side just (re-)connected Thomas Huth
2023-08-17 10:32 ` Daniel P. Berrangé
2023-08-17 12:00 ` Thomas Huth
2023-08-17 13:06 ` Daniel P. Berrangé
2023-08-17 13:47 ` Marc-André Lureau
2023-08-17 17:09 ` Thomas Huth
2023-08-28 12:23 ` Thomas Huth
2023-09-28 5:18 ` Thomas Huth
2023-08-23 9:44 ` Amaury Pouly [this message]
2023-09-28 11:10 ` Daniel P. Berrangé
2025-03-12 12:18 ` Philippe Mathieu-Daudé
2025-03-12 12:29 ` Thomas Huth
2025-03-12 14:17 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4505709.LvFx2qVVIh@jamesbond \
--to=amaury.pouly@lowrisc.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mhartmay@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).