From: Fabrice Bellard <fabrice@bellard.org>
To: dwmw2@infradead.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Don't include <linux/compiler.h>
Date: Mon, 11 Sep 2006 22:13:59 +0200 [thread overview]
Message-ID: <4505C387.5000801@bellard.org> (raw)
In-Reply-To: <1157959380.2977.191.camel@pmac.infradead.org>
The problem is that without this header it does not compile on some
distributions (see old mailing list messages).
Fabrice.
David Woodhouse wrote:
> This file is not one of the kernel headers which is exported to
> userspace by the kernel. It should not exist in /usr/include/linux and
> certainly shouldn't be included by userspace programs.
>
> diff -Naupr qemu-0.8.2.orig/usb-linux.c qemu-0.8.2/usb-linux.c
> --- qemu-0.8.2.orig/usb-linux.c 2006-07-22 19:23:34.000000000 +0200
> +++ qemu-0.8.2/usb-linux.c 2006-08-23 18:47:16.000000000 +0200
> @@ -26,7 +26,6 @@
> #if defined(__linux__)
> #include <dirent.h>
> #include <sys/ioctl.h>
> -#include <linux/compiler.h>
> #include <linux/usbdevice_fs.h>
> #include <linux/version.h>
>
>
next prev parent reply other threads:[~2006-09-11 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-11 7:23 [Qemu-devel] [PATCH] Don't include <linux/compiler.h> David Woodhouse
2006-09-11 20:13 ` Fabrice Bellard [this message]
2006-09-11 21:33 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4505C387.5000801@bellard.org \
--to=fabrice@bellard.org \
--cc=dwmw2@infradead.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).