From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIbGc-0008Ds-BI for qemu-devel@nongnu.org; Thu, 21 Mar 2013 04:54:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIbGb-0000ub-F1 for qemu-devel@nongnu.org; Thu, 21 Mar 2013 04:54:34 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:58115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIbGb-0000uM-5V for qemu-devel@nongnu.org; Thu, 21 Mar 2013 04:54:33 -0400 Date: Thu, 21 Mar 2013 04:54:32 -0400 (EDT) From: Alon Levy Message-ID: <450950349.12338221.1363856072322.JavaMail.root@redhat.com> In-Reply-To: <514AAE79.8080804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: amit shah , hdegoede@redhat.com, Anthony Liguori , qemu-devel@nongnu.org > On 03/20/13 17:59, Alon Levy wrote: > >> > I thought we previously discussed this? Just implement a > >> > migration > >> > hook > >> > in the spice code. > > We did and Gerd objected so I sent this to have this discussion > > again, with him. > > migration section != migration hook. > > I think what Anthony asks for is to register a migration state > notifier > and handle the post-migration action there instead of adding a > chardev > callback. Yes, but then to know if the frontend (aka guest, aka virtio-console/virtio-serial-bus) is connected we need some api in the chardev layer, which is what I asked about. That way spice-qemu-char doesn't need to keep any vmstate. > > cheers, > Gerd > > > >