From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GNyg5-0005FW-GK
	for qemu-devel@nongnu.org; Thu, 14 Sep 2006 17:23:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GNyg4-0005Ey-2g
	for qemu-devel@nongnu.org; Thu, 14 Sep 2006 17:23:21 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GNyg3-0005Ep-Rf
	for qemu-devel@nongnu.org; Thu, 14 Sep 2006 17:23:19 -0400
Received: from [84.96.92.61] (helo=sMtp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1GNyi5-0006sY-Dk
	for qemu-devel@nongnu.org; Thu, 14 Sep 2006 17:25:25 -0400
Received: from [84.102.211.173] by sp604002mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0J5L005D3Q2TFZS0@sp604002mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Thu, 14 Sep 2006 23:23:17 +0200 (CEST)
Date: Thu, 14 Sep 2006 23:23:50 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] cpustate patch
In-reply-to: <564d96fb0609141348y3bf4bbaat539cea1694c5c02d@mail.gmail.com>
Message-id: <4509C866.2070909@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: QUOTED-PRINTABLE
References: <564d96fb0609141348y3bf4bbaat539cea1694c5c02d@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Rafael Esp=EDndola wrote:
> While hunting a tls related bug in ARM emulation, I found that that
> qemu distributed with scratchbox includes the attached patch.
>=20
> Without the patch python's configure halts when checking for the
> -pthread option.
>=20
> The patch inverts the order of the list and makes the code simpler.=
 I
> think that there is a remaining problem, if first_cpu =3D=3D NULL t=
hen
> env->cpu_index is not initialized. Should an else be added?
>=20
> Any thoughts on the patch?

For consistency I prefer that the first cpu of the list is number zer=
o,=20
so I prefer to leave the code as it is now.

Regards,

Fabrice.