Re: [Qemu-devel] [PATCH v2] Acceptance tests: add Linux initrd checking test

[Wainer dos Santos Moschetta <wainersm@redhat.com>]

Hi Eduardo,

Since you have already queued this patch for 4.0, I would like to know 
if I should send a v3 to address Eric's review. Or if you can edit the 
patch yourself given the changes are trivial.

Thanks!
- Wainer

On 11/13/2018 02:08 PM, Eric Blake wrote:
> On 11/9/18 12:21 PM, Wainer dos Santos Moschetta wrote:
>> QEMU used to exits with a not accurate error message when
>
> s/exits/exit/
> s/a not accurate/an inaccurate/
>
>> an initrd > 2GiB was passed. That was fixed on patch:
>>
>>     commit f3839fda5771596152b75dd1e1a6d050e6e6e380
>>     Author: Li Zhijian <lizhijian@cn.fujitsu.com>
>>     Date:   Thu Sep 13 18:07:13 2018 +0800
>>
>>          change get_image_size return type to int64_t
>>
>> This change adds a regression test for that fix. It starts
>> QEMU with a 2GiB dummy initrd, and check it evaluates the file
>
> s/check/checks that/
>
>> size correctly and prints accurate message.
>
> s/accurate/an accurate/
>
>>
>> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>> Reviewed-by: Caio Carrara <ccarrara@redhat.com>
>> Reviewed-by: Cleber Rosa <crosa@redhat.com>
>> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>
>