From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNIpv-0001nr-5U for qemu-devel@nongnu.org; Thu, 15 Nov 2018 09:41:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNIpX-0000XU-5s for qemu-devel@nongnu.org; Thu, 15 Nov 2018 09:41:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49282) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNIpW-0000Vt-UB for qemu-devel@nongnu.org; Thu, 15 Nov 2018 09:41:15 -0500 References: <20181109182153.5390-1-wainersm@redhat.com> From: Wainer dos Santos Moschetta Message-ID: <450af60f-0da2-0b53-0ac3-10ceb90fc417@redhat.com> Date: Thu, 15 Nov 2018 12:41:09 -0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] Acceptance tests: add Linux initrd checking test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org, ehabkost@redhat.com Cc: crosa@redhat.com, philmd@redhat.com, lizhijian@cn.fujitsu.com, ccarrara@redhat.com Hi Eduardo, Since you have already queued this patch for 4.0, I would like to know=20 if I should send a v3 to address Eric's review. Or if you can edit the=20 patch yourself given the changes are trivial. Thanks! - Wainer On 11/13/2018 02:08 PM, Eric Blake wrote: > On 11/9/18 12:21 PM, Wainer dos Santos Moschetta wrote: >> QEMU used to exits with a not accurate error message when > > s/exits/exit/ > s/a not accurate/an inaccurate/ > >> an initrd > 2GiB was passed. That was fixed on patch: >> >> =C2=A0=C2=A0=C2=A0=C2=A0commit f3839fda5771596152b75dd1e1a6d050e6e6e38= 0 >> =C2=A0=C2=A0=C2=A0=C2=A0Author: Li Zhijian >> =C2=A0=C2=A0=C2=A0=C2=A0Date:=C2=A0=C2=A0 Thu Sep 13 18:07:13 2018 +08= 00 >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 change get_image_size= return type to int64_t >> >> This change adds a regression test for that fix. It starts >> QEMU with a 2GiB dummy initrd, and check it evaluates the file > > s/check/checks that/ > >> size correctly and prints accurate message. > > s/accurate/an accurate/ > >> >> Signed-off-by: Wainer dos Santos Moschetta >> Reviewed-by: Caio Carrara >> Reviewed-by: Cleber Rosa >> Reviewed-by: Eduardo Habkost >> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >> Tested-by: Philippe Mathieu-Daud=C3=A9 >> --- > >