From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
vsementsov@virtuozzo.com, Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/7] bitmaps: remove x- prefix from QMP api
Date: Mon, 17 Dec 2018 16:14:54 -0500 [thread overview]
Message-ID: <45156be0-6524-2fb0-105d-a47d27703c35@redhat.com> (raw)
In-Reply-To: <20181214231512.5295-1-jsnow@redhat.com>
On 12/14/18 6:15 PM, John Snow wrote:
> Touch up a few last things and remove the x- prefix.
>
> V3:
> - Reworked qmp_log to pretty-print the outgoing command, too [Vladimir]
> - Modified test to log only bitmap information [Vladimir]
> - Test disable/enable transaction toggle [Eric]
>
> Note that the filter I added is now unused, but I think we will want it
> and it's small enough, so I'm going to check it in anyway. If you disagree,
> I'll just drop the patch instead.
>
> --js
>
> John Snow (7):
> blockdev: abort transactions in reverse order
> blockdev: n-ary bitmap merge
> block: remove 'x' prefix from experimental bitmap APIs
> iotests.py: don't abort if IMGKEYSECRET is undefined
> iotests: add filter_generated_node_ids
> iotests: allow pretty-print for qmp_log
> iotests: add iotest 236 for testing bitmap merge
>
> blockdev.c | 96 +++++++++-------
> qapi/block-core.json | 56 +++++-----
> qapi/transaction.json | 12 +-
> tests/qemu-iotests/223 | 4 +-
> tests/qemu-iotests/236 | 124 +++++++++++++++++++++
> tests/qemu-iotests/236.out | 200 ++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> tests/qemu-iotests/iotests.py | 22 +++-
> 8 files changed, 436 insertions(+), 79 deletions(-)
> create mode 100755 tests/qemu-iotests/236
> create mode 100644 tests/qemu-iotests/236.out
>
Thanks, I'm staging patches 1-5 and I'll send the PR once we get to the
bottom of patches 6 and 7, just to keep volume on the list down.
--js
next prev parent reply other threads:[~2018-12-17 21:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 23:15 [Qemu-devel] [PATCH v3 0/7] bitmaps: remove x- prefix from QMP api John Snow
2018-12-14 23:15 ` [Qemu-devel] [PATCH v3 1/7] blockdev: abort transactions in reverse order John Snow
2018-12-14 23:15 ` [Qemu-devel] [PATCH v3 2/7] blockdev: n-ary bitmap merge John Snow
2018-12-14 23:15 ` [Qemu-devel] [PATCH v3 3/7] block: remove 'x' prefix from experimental bitmap APIs John Snow
2018-12-14 23:15 ` [Qemu-devel] [PATCH v3 4/7] iotests.py: don't abort if IMGKEYSECRET is undefined John Snow
2018-12-14 23:15 ` [Qemu-devel] [PATCH v3 6/7] iotests: allow pretty-print for qmp_log John Snow
2018-12-17 14:26 ` Vladimir Sementsov-Ogievskiy
2018-12-17 16:37 ` Vladimir Sementsov-Ogievskiy
2018-12-17 19:21 ` John Snow
2018-12-18 8:37 ` Vladimir Sementsov-Ogievskiy
2018-12-14 23:15 ` [Qemu-devel] [PATCH v3 7/7] iotests: add iotest 236 for testing bitmap merge John Snow
2018-12-17 15:48 ` Vladimir Sementsov-Ogievskiy
2018-12-17 21:32 ` John Snow
2018-12-18 8:45 ` Vladimir Sementsov-Ogievskiy
2018-12-18 9:20 ` Vladimir Sementsov-Ogievskiy
2018-12-14 23:32 ` [Qemu-devel] [PATCH v3 5/7 RESEND] iotests: add filter_generated_node_ids John Snow
[not found] ` <20181214231512.5295-6-jsnow@redhat.com>
2018-12-17 14:37 ` [Qemu-devel] [PATCH v3 5/7] " Vladimir Sementsov-Ogievskiy
2018-12-17 21:14 ` John Snow [this message]
2018-12-20 1:24 ` [Qemu-devel] [PATCH v3 0/7] bitmaps: remove x- prefix from QMP api John Snow
2018-12-23 14:28 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45156be0-6524-2fb0-105d-a47d27703c35@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).