From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZ0EH-0004s0-QG for qemu-devel@nongnu.org; Mon, 17 Dec 2018 16:15:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZ0EF-0004pN-8i for qemu-devel@nongnu.org; Mon, 17 Dec 2018 16:15:09 -0500 References: <20181214231512.5295-1-jsnow@redhat.com> From: John Snow Message-ID: <45156be0-6524-2fb0-105d-a47d27703c35@redhat.com> Date: Mon, 17 Dec 2018 16:14:54 -0500 MIME-Version: 1.0 In-Reply-To: <20181214231512.5295-1-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/7] bitmaps: remove x- prefix from QMP api List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Kevin Wolf , vsementsov@virtuozzo.com, Markus Armbruster , Max Reitz On 12/14/18 6:15 PM, John Snow wrote: > Touch up a few last things and remove the x- prefix. > > V3: > - Reworked qmp_log to pretty-print the outgoing command, too [Vladimir] > - Modified test to log only bitmap information [Vladimir] > - Test disable/enable transaction toggle [Eric] > > Note that the filter I added is now unused, but I think we will want it > and it's small enough, so I'm going to check it in anyway. If you disagree, > I'll just drop the patch instead. > > --js > > John Snow (7): > blockdev: abort transactions in reverse order > blockdev: n-ary bitmap merge > block: remove 'x' prefix from experimental bitmap APIs > iotests.py: don't abort if IMGKEYSECRET is undefined > iotests: add filter_generated_node_ids > iotests: allow pretty-print for qmp_log > iotests: add iotest 236 for testing bitmap merge > > blockdev.c | 96 +++++++++------- > qapi/block-core.json | 56 +++++----- > qapi/transaction.json | 12 +- > tests/qemu-iotests/223 | 4 +- > tests/qemu-iotests/236 | 124 +++++++++++++++++++++ > tests/qemu-iotests/236.out | 200 ++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > tests/qemu-iotests/iotests.py | 22 +++- > 8 files changed, 436 insertions(+), 79 deletions(-) > create mode 100755 tests/qemu-iotests/236 > create mode 100644 tests/qemu-iotests/236.out > Thanks, I'm staging patches 1-5 and I'll send the PR once we get to the bottom of patches 6 and 7, just to keep volume on the list down. --js