From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIJP4-0005pP-Nq for qemu-devel@nongnu.org; Mon, 14 May 2018 15:45:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIJP3-0002AQ-W0 for qemu-devel@nongnu.org; Mon, 14 May 2018 15:45:02 -0400 References: <20180509162637.15575-1-kwolf@redhat.com> <20180509162637.15575-8-kwolf@redhat.com> <91b7384b-25f4-2141-8794-d1319aa19c2d@redhat.com> From: John Snow Message-ID: <451d7e65-4a0a-f697-ffb4-ff50206d60f7@redhat.com> Date: Mon, 14 May 2018 15:44:57 -0400 MIME-Version: 1.0 In-Reply-To: <91b7384b-25f4-2141-8794-d1319aa19c2d@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/42] blockjob: Remove block_job_pause/resume_all() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Kevin Wolf , qemu-block@nongnu.org Cc: jcody@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org On 05/11/2018 06:30 PM, Max Reitz wrote: > On 2018-05-09 18:26, Kevin Wolf wrote: >> Commit 81193349 removed the only use of block_job_pause/resume_all(), >> which was in bdrv_drain_all(). The functions are now unused and can be >> removed. > > I have a strange liking for all-digit commit hash prefixes. > >> Signed-off-by: Kevin Wolf >> --- >> include/block/blockjob_int.h | 14 -------------- >> blockjob.c | 27 --------------------------- >> 2 files changed, 41 deletions(-) > And all deletion diffstats. > Reviewed-by: Max Reitz > Reviewed-by: John Snow