From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41036)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1btNDu-0004iZ-QU
	for qemu-devel@nongnu.org; Sun, 09 Oct 2016 19:09:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1btNDq-0005K9-MX
	for qemu-devel@nongnu.org; Sun, 09 Oct 2016 19:09:38 -0400
Sender: Richard Henderson <rth7680@gmail.com>
References: <1475866623-16841-1-git-send-email-nikunj@linux.vnet.ibm.com>
	<1475866623-16841-3-git-send-email-nikunj@linux.vnet.ibm.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <452e40f3-bf23-4e3f-7e44-d663ecae75a2@twiddle.net>
Date: Sun, 9 Oct 2016 18:09:31 -0500
MIME-Version: 1.0
In-Reply-To: <1475866623-16841-3-git-send-email-nikunj@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] target-ppc: implement vnegw/d
 instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org, benh@kernel.crashing.org

On 10/07/2016 01:57 PM, Nikunj A Dadhania wrote:
> +        r->element[i] = (~(b->element[i]) + 1) & mask;              \

Any reason you're not writing this as a proper negate?


r~