* [PATCH] coreaudio: Notify error in coreaudio_init_out
@ 2022-02-26 10:02 Akihiko Odaki
2022-02-26 10:16 ` Christian Schoenebeck
0 siblings, 1 reply; 4+ messages in thread
From: Akihiko Odaki @ 2022-02-26 10:02 UTC (permalink / raw)
Cc: Christian Schoenebeck, qemu-devel, Akihiko Odaki, Gerd Hoffmann
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
---
audio/coreaudio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index d8a21d3e507..d7cfdcc4fc4 100644
--- a/audio/coreaudio.c
+++ b/audio/coreaudio.c
@@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
coreaudio_playback_logerr(status,
"Could not remove voice property change listener\n");
}
+
+ return -1;
}
return 0;
--
2.32.0 (Apple Git-132)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] coreaudio: Notify error in coreaudio_init_out
2022-02-26 10:02 [PATCH] coreaudio: Notify error in coreaudio_init_out Akihiko Odaki
@ 2022-02-26 10:16 ` Christian Schoenebeck
2022-02-26 10:18 ` Akihiko Odaki
0 siblings, 1 reply; 4+ messages in thread
From: Christian Schoenebeck @ 2022-02-26 10:16 UTC (permalink / raw)
To: qemu-devel; +Cc: Akihiko Odaki, Gerd Hoffmann
On Samstag, 26. Februar 2022 11:02:48 CET Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
> audio/coreaudio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/audio/coreaudio.c b/audio/coreaudio.c
> index d8a21d3e507..d7cfdcc4fc4 100644
> --- a/audio/coreaudio.c
> +++ b/audio/coreaudio.c
> @@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct
> audsettings *as, coreaudio_playback_logerr(status,
> "Could not remove voice property
> change listener\n"); }
> +
> + return -1;
> }
>
> return 0;
Is this a pure theoretical fix, or does it actually fix an actually
encountered misbehaviour? I don't see any explanation in the commit log. I
mean the branch here is about removing a listener only.
Best regards,
Christian Schoenebeck
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] coreaudio: Notify error in coreaudio_init_out
2022-02-26 10:16 ` Christian Schoenebeck
@ 2022-02-26 10:18 ` Akihiko Odaki
2022-02-26 11:30 ` Christian Schoenebeck
0 siblings, 1 reply; 4+ messages in thread
From: Akihiko Odaki @ 2022-02-26 10:18 UTC (permalink / raw)
To: Christian Schoenebeck, qemu-devel; +Cc: Gerd Hoffmann
On 2022/02/26 19:16, Christian Schoenebeck wrote:
> On Samstag, 26. Februar 2022 11:02:48 CET Akihiko Odaki wrote:
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
>> ---
>> audio/coreaudio.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/audio/coreaudio.c b/audio/coreaudio.c
>> index d8a21d3e507..d7cfdcc4fc4 100644
>> --- a/audio/coreaudio.c
>> +++ b/audio/coreaudio.c
>> @@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct
>> audsettings *as, coreaudio_playback_logerr(status,
>> "Could not remove voice property
>> change listener\n"); }
>> +
>> + return -1;
>> }
>>
>> return 0;
>
> Is this a pure theoretical fix, or does it actually fix an actually
> encountered misbehaviour? I don't see any explanation in the commit log. I
> mean the branch here is about removing a listener only.
>
> Best regards,
> Christian Schoenebeck
>
>
I saw branching to this block results in abort as core->hw.samples is
not set.
Regards,
Akihiko Odaki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] coreaudio: Notify error in coreaudio_init_out
2022-02-26 10:18 ` Akihiko Odaki
@ 2022-02-26 11:30 ` Christian Schoenebeck
0 siblings, 0 replies; 4+ messages in thread
From: Christian Schoenebeck @ 2022-02-26 11:30 UTC (permalink / raw)
To: qemu-devel; +Cc: Akihiko Odaki, Gerd Hoffmann
On Samstag, 26. Februar 2022 11:18:44 CET Akihiko Odaki wrote:
> On 2022/02/26 19:16, Christian Schoenebeck wrote:
> > On Samstag, 26. Februar 2022 11:02:48 CET Akihiko Odaki wrote:
> >> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> >> ---
> >>
> >> audio/coreaudio.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/audio/coreaudio.c b/audio/coreaudio.c
> >> index d8a21d3e507..d7cfdcc4fc4 100644
> >> --- a/audio/coreaudio.c
> >> +++ b/audio/coreaudio.c
> >> @@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct
> >> audsettings *as, coreaudio_playback_logerr(status,
> >>
> >> "Could not remove voice property
> >>
> >> change listener\n"); }
> >> +
> >> + return -1;
> >>
> >> }
> >>
> >> return 0;
> >
> > Is this a pure theoretical fix, or does it actually fix an actually
> > encountered misbehaviour? I don't see any explanation in the commit log. I
> > mean the branch here is about removing a listener only.
> >
> > Best regards,
> > Christian Schoenebeck
>
> I saw branching to this block results in abort as core->hw.samples is
> not set.
Ok, then please add an appropriate description to the commit log of what your
observed. Except of that:
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Best regards,
Christian Schoenebeck
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-26 11:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-26 10:02 [PATCH] coreaudio: Notify error in coreaudio_init_out Akihiko Odaki
2022-02-26 10:16 ` Christian Schoenebeck
2022-02-26 10:18 ` Akihiko Odaki
2022-02-26 11:30 ` Christian Schoenebeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).