Re: [Qemu-devel] [PATCH v6 0/8] ARM virt: ACPI memory hotplug support

[Auger Eric <eric.auger@redhat.com>]

Hi Peter,

On 7/1/19 5:55 PM, Auger Eric wrote:
> Hi Peter,
> 
> On 7/1/19 3:52 PM, Peter Maydell wrote:
>> On Tue, 25 Jun 2019 at 13:15, Shameer Kolothum
>> <shameerali.kolothum.thodi@huawei.com> wrote:
>>>
>>> This series is an attempt to provide device memory hotplug support
>>> on ARM virt platform. This is based on Eric's recent works here[1]
>>> and carries some of the pc-dimm related patches dropped from his
>>> series.
>>>
>>> The kernel support for arm64 memory hot add was added recently by
>>> Robin and hence the guest kernel should be => 5.0-rc1.
>>>
>>> NVDIM support is not included currently as we still have an unresolved
>>> issue while hot adding NVDIMM[2]. However NVDIMM cold plug patches
>>> can be included, but not done for now, for keeping it simple.
>>>
>>> This makes use of GED device to sent hotplug ACPI events to the
>>> Guest. GED code is based on Nemu. Thanks to the efforts of Samuel and
>>> Sebastien to add the hardware-reduced support to Nemu using GED
>>> device[3]. (Please shout if I got the author/signed-off wrong for
>>> those patches or missed any names).
>>>
>>> This is sanity tested on a HiSilicon ARM64 platform and appreciate
>>> any further testing.
>>
>> Hi; this seems to fail 'make check' (on an x86 host):
>>
>> acpi-test: Warning! DSDT binary file mismatch. Actual
>> [aml:/tmp/aml-01P83Z], Expected [aml:tests/data/acpi/virt/DSDT].
>> acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-4ZP83Z.dsl,
>> aml:/tmp/aml-01P83Z], Expected [asl:/tmp/asl-H7UE4Z.dsl,
>> aml:tests/data/acpi/virt/DSDT].
>> **
>> ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/bios-tables-test.c:434:test_acpi_asl:
>> assertion failed: (all_tables_match)
> I fail to reproduce on my laptop:
> 
> make check-qtest-x86_64 executes
> 
>   TEST    check-qtest-x86_64: tests/bios-tables-test
> 
> and it does not seem to complain. But maybe I misunderstand the framework.
> 
> If I were able to reproduce I understand this is a matter to regenerate
> the files we compare with by using
> tests/data/acpi/rebuild-expected-aml.sh, right?

I reproduced the failure with a TCG aarch64 target on x86.
I sent a separate
"[PATCH] tests: Update DSDT ACPI table for arm/virt board with PCDIMM
related changes" patch that should fix the issue.

checkpatch complains with an "ERROR: Does not appear to be a
unified-diff format patch" but I checked similar patches like d2a1b1d602
("tests: update acpi expected files") produce the same so I hope it's fine.

Thanks

Eric

Thanks

Eric
> 
> Thanks
> 
> Eric
> 
> 
>> ERROR - Bail out!
>> ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/bios-tables-test.c:434:test_acpi_asl:
>> assertion failed: (all_tables_match)
>> Aborted (core dumped)
>> /home/petmay01/linaro/qemu-from-laptop/qemu/tests/Makefile.include:894:
>> recipe for target 'check-qtest-aarch64' failed
>>
>> Is there a need to update the reference DSDT used by the test?
>>
>> thanks
>> -- PMM
>>
>