From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1101FD6A224 for ; Thu, 14 Nov 2024 18:25:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBeVp-0000qQ-A2; Thu, 14 Nov 2024 13:24:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBeVa-0000mC-NZ for qemu-devel@nongnu.org; Thu, 14 Nov 2024 13:23:58 -0500 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBeVZ-0000KX-3m for qemu-devel@nongnu.org; Thu, 14 Nov 2024 13:23:58 -0500 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-720be27db74so751492b3a.1 for ; Thu, 14 Nov 2024 10:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731608635; x=1732213435; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pWrlQmqkGFoVZPKM2LGF3oDBVshqqzwKduuS1JkstNA=; b=OhK5lBhTK4SGohRKzXjvIbiUKjiABv2GQ7HDtvEl5tKmlHMd8X1OekWNg8DHOP89GH 6dtrKA1Qf300VaKa5GPgG+ZfHwgi6nY7ZWYIXh5f8AKnlrj8GHDHCRqPTBNbHJemrj90 5l7vUKAHAfGkEAsMNM6ZVy5EdtVXaToorOezXMHBgif36V0m/7lrngS+QvWQR3kLvdhP EZKWWL+aiOqx7/fVjFQNCFKF7OEV/9YkedWxb3MND0ZZ1+bl5ommW2AdVo/q0rkGS2Nn T27tmvsN8K9m3EJFgITPbFUn/874ZrMSFmspBnGPHcV+jITK71BzlEpsIs/QAC3kayDS zj9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731608635; x=1732213435; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pWrlQmqkGFoVZPKM2LGF3oDBVshqqzwKduuS1JkstNA=; b=ES6SHjjtZg8Eyv65c4dVSxjjukkY5p/1nRCto4y6RTEyGJSizAlwziBtx/b1HqfQda f+NZ4khtPJfaPoc+gm+dec6TinBGQkhQbbUZiBFAeGiscr1x7IhaQWOlJ2q/B+2GnM5c xcyOwTSOWqVaG+kTtRqr1wBIwT87avDfWK0HnMjjZ7cbhUzzzP8DE+ejUOj+MdpnL3El P9H2jIBMQWE8JCJTyzNxflcKOLmhllMd78fFW+ySj3EjpxcCmKwB2BuXZ0edpjZ2ZG0V FW7Zu6jXV+rbl9pHAfUi+sIG5jZQvQeqRWiOQtrH8cQwxTo1irnTzM8wha7xipgc4hxh iHUQ== X-Forwarded-Encrypted: i=1; AJvYcCVdRZfB/ff8Ay3nQthzzieR8BsxXdjaHhIsimtGJhduJEePjH8JCYOOaFJBBAo6P0Pf0EQHD3qmjX3M@nongnu.org X-Gm-Message-State: AOJu0Yy+AAebxkYNg8lGDoq6f1hEi/u0NDRNG5Ur3ccaYRQBKpxisW6+ +agMYhtR7V6/efY6L9vofTCG/so8WtJBjCKnacThaqE5GeT/vKmuxyE8GGThNSs= X-Google-Smtp-Source: AGHT+IFaM4tPkOHim3pBzQlGQstO9lIzVCJDZj4sa8QMuEUhTc9wH21LsRXyx0yzd4mGebp4quQW4Q== X-Received: by 2002:a05:6a00:190c:b0:724:66cf:163f with SMTP id d2e1a72fcca58-72475f97125mr132951b3a.3.1731608635245; Thu, 14 Nov 2024 10:23:55 -0800 (PST) Received: from [192.168.0.4] ([71.212.136.242]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7246a6e716esm1550837b3a.59.2024.11.14.10.23.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 10:23:54 -0800 (PST) Message-ID: <453e90d6-f8b8-436b-b3a0-45c11fd8e813@linaro.org> Date: Thu, 14 Nov 2024 10:23:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/24] accel/tcg: Include missing 'exec/translation-block.h' header To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , Anton Johansson , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Thomas Huth , qemu-arm@nongnu.org, Peter Xu , Pierrick Bouvier , qemu-riscv@nongnu.org, David Hildenbrand , Peter Maydell , =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-s390x@nongnu.org References: <20241114011310.3615-1-philmd@linaro.org> <20241114011310.3615-5-philmd@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: <20241114011310.3615-5-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/13/24 17:12, Philippe Mathieu-Daudé wrote: > TB compile flags are defined in "exec/translation-block.h". > Include it in order to avoid when refactoring: > > accel/tcg/tcg-accel-ops.c:62:36: error: use of undeclared identifier 'CF_CLUSTER_SHIFT' > 62 | cflags = cpu->cluster_index << CF_CLUSTER_SHIFT; > | ^ > accel/tcg/tcg-accel-ops.c:64:26: error: use of undeclared identifier 'CF_PARALLEL' > 64 | cflags |= parallel ? CF_PARALLEL : 0; > | ^ > accel/tcg/tcg-accel-ops.c:65:34: error: use of undeclared identifier 'CF_USE_ICOUNT' > 65 | cflags |= icount_enabled() ? CF_USE_ICOUNT : 0; > | ^ > > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/tcg/tcg-accel-ops.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~ > > diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c > index 3c19e68a79..22486c5dff 100644 > --- a/accel/tcg/tcg-accel-ops.c > +++ b/accel/tcg/tcg-accel-ops.c > @@ -35,6 +35,7 @@ > #include "exec/exec-all.h" > #include "exec/hwaddr.h" > #include "exec/tb-flush.h" > +#include "exec/translation-block.h" > #include "gdbstub/enums.h" > > #include "hw/core/cpu.h"