From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ7gs-0000jU-MU for qemu-devel@nongnu.org; Fri, 22 Mar 2013 15:31:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJ7gr-0006XW-FQ for qemu-devel@nongnu.org; Fri, 22 Mar 2013 15:31:50 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:50122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ7gr-0006X8-8J for qemu-devel@nongnu.org; Fri, 22 Mar 2013 15:31:49 -0400 Date: Fri, 22 Mar 2013 15:31:46 -0400 (EDT) From: Alon Levy Message-ID: <455165072.13533249.1363980706497.JavaMail.root@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 12/26] hw/ccid-card-passthru.c: add atr check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: mlureau@redhat.com, qemu-devel@nongnu.org > On Mon, Mar 18, 2013 at 2:10 PM, Alon Levy wrote: > > + if (len > 2 + historical_length + opt_bytes) { > > + DPRINTF(card, D_WARN, > > + "atr too long: len %d, but hist/opt %d/%d, T1 0x%X\n", > > + len, historical_length, opt_bytes, data[1]); > > + /* let it through */ >=20 > Why "let it through" if it's too long? I know windows doesn't like too short, but no idea about too long. Haven't = seen this in practice yet (well, we control the other end too, but I saw no= reason to fail it at this point). >=20 >=20 > -- > Marc-Andr=C3=A9 Lureau >=20 >=20