qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re:  Debugging with paging enabled
Date: Wed, 08 Nov 2006 23:15:14 +0100	[thread overview]
Message-ID: <455256F2.6090006@bellard.org> (raw)
In-Reply-To: <6310169804.20061108221303@kilgus.net>

Marcel Kilgus wrote:
> /me wrote:
> 
>>Having to always set them both in the high and low area is a bit
>>cumbersome to say the least. Any suggestion on what I'm missing or can
>>do to get breakpoints working properly again?
> 
> 
> Okay, the QEMU source code was a lot more readable than I expected it
> to be, so I had a look myself. For the record, my solution to my
> problem is thus:
> 
> /tmptmp/qemu-0.8.2/target-i386 $ diff translate.bak translate.c
> 6425c6425
> <                 if (env->breakpoints[j] == pc_ptr) {
> ---
> 
>>                if (env->breakpoints[j] == pc_ptr - dc->cs_base) {
> 
> 
> Now everything works as expected. Don't know if this breaks any other
> scenarios, though.

Hi,

The breakpoints are set for a given virtual address. So IMHO testing 
only the EIP value instead of EIP + CS.base is not logical...

Regards,

Fabrice.

  reply	other threads:[~2006-11-08 22:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-08  2:30 [Qemu-devel] Debugging with paging enabled Marcel Kilgus
2006-11-08 21:13 ` [Qemu-devel] " Marcel Kilgus
2006-11-08 22:15   ` Fabrice Bellard [this message]
2006-11-08 23:33     ` Marcel Kilgus
2006-11-08 23:42       ` Daniel Jacobowitz
2006-11-08 23:57         ` Marcel Kilgus
2006-11-09  2:24           ` Daniel Jacobowitz
2006-11-10 13:14           ` andrzej zaborowski
2006-11-10 14:31             ` Marcel Kilgus
2006-11-10 15:56               ` Paul Brook
2006-11-10 16:14                 ` Marcel Kilgus
2006-11-10 17:10                 ` Daniel Jacobowitz
2006-11-10 19:01                   ` Marcel Kilgus
2006-11-10 19:07                     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=455256F2.6090006@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).