From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GmuHm-0000vA-9H for qemu-devel@nongnu.org; Wed, 22 Nov 2006 10:45:19 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GmuHk-0000to-Q6 for qemu-devel@nongnu.org; Wed, 22 Nov 2006 10:45:17 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GmuHk-0000tM-ER for qemu-devel@nongnu.org; Wed, 22 Nov 2006 10:45:16 -0500 Received: from [158.109.168.138] (helo=istanbul.uab.es) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GmuHj-000087-GA for qemu-devel@nongnu.org; Wed, 22 Nov 2006 10:45:16 -0500 Received: from istanbul.uab.es (localhost [127.0.0.1]) by istanbul.uab.es (Sun Java System Messaging Server 6.1 HotFix 0.10 (built Jan 6 2005)) with ESMTP id <0J95005JZ2FD8W90@istanbul.uab.es> for qemu-devel@nongnu.org; Wed, 22 Nov 2006 16:45:13 +0100 (CET) Received: from [158.109.70.47] by istanbul.uab.es (Sun Java System Messaging Server 6.1 HotFix 0.10 (built Jan 6 2005)) with ESMTP id <0J95001I02FD2O60@istanbul.uab.es> for qemu-devel@nongnu.org; Wed, 22 Nov 2006 16:45:13 +0100 (CET) Date: Wed, 22 Nov 2006 16:47:09 +0100 From: =?ISO-8859-1?Q?M=E0rius_Mont=F3n?= Subject: Re: [Qemu-devel] SystemC Cosimulation In-reply-to: Message-id: <456470FD.4080204@uab.es> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_9Zy87HzGIAWTjw/CGBRpKg)" References: <3518719F06577C4F85DA618E3C37AB910769CC47@nimbus.ott.qnx.com> <"45 62CAC4.4010209"@uab.es> <45644A3A.4020507@uab.es> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. --Boundary_(ID_9Zy87HzGIAWTjw/CGBRpKg) Content-type: multipart/alternative; boundary="Boundary_(ID_EeNjQUvEZLQ7EN2O2uVmTw)" --Boundary_(ID_EeNjQUvEZLQ7EN2O2uVmTw) Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: QUOTED-PRINTABLE Hi, of course comments are welcome! And yes, you're right about all of them. we will fix it ASAP. In other hand, we don't expect to do this plugin official to QEMU. we think it's too specific and it's useless to "normal" qemu user. By the way, I'd like ask to mailing list if people think it's good enough to make this work official inside QEMU. Thanks for suggestions and answers! M=E0rius Johannes Schindelin wrote: > Hi, > > On Wed, 22 Nov 2006, M=E0rius Mont=F3n wrote: > > =20 >> Our work on SystemC + QEMU has been published: >> http://cephis.uab.es/proj/public/qemu/ >> =20 > > Great! > > A few comments (as you said they are welcome): > > - As far as I saw, you use C++, but the code is simple enough to be= =20 > written in C. This is needed by SystemC, correct? > > - the c++ compiler is typically called CXX, not CC2, in Makefiles > > - your diff contains changes to arm-user/Makefile and likewise for = other=20 > targets. These Makefiles are just copies of Makefile.target; you sh= ould=20 > patch only this. > > - there are backup files in your patch > > - some namings are non-English ("llegir", "escriure"). Please use t= he=20 > English terms "read" and "write" instead > > - (minor nit) the indentation of hw/pc.c is incorrect > > - (minor nit) the file names and function names in QEmu are lower c= ase=20 > ("SCLink.c", "SC_init()") > > - since the SystemC code is not target specific (or is it?), you co= uld=20 > have it in its own subdirectory, like the audio/ stuff > > - this code depends on SystemC being present, right? You should add= a=20 > configure option, and disable this code (including CXX linking) if = the=20 > option was not passed -- there are probably many more users without= the=20 > necessary dependencies > > - if you want to submit it to the list, you can do so as an attache= d=20 > gzipped patch > > Ciao, > Dscho > > =20 > -------------------------------------------------------------------= ----- > > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel > =20 --=20 M=E0rius Mont=F3n i Maci=E1n marius.monton@uab.cat http://cephis.uab.es Hardware Engineer CEPHIS Centre de Prototips i Solucions Hardware-Software Dep. Microelectr=F2nica i Sistemes Electr=F2nics ETSE - Universitat Aut=F2noma de Barcelona (UAB) =09Phone: +34 935 81= 3 534 Fax: +34 935 813 033 QC-2090D. ETSE. Campus UAB. 080193 Bellaterra --Boundary_(ID_EeNjQUvEZLQ7EN2O2uVmTw) Content-type: text/html; charset=ISO-8859-1 Content-transfer-encoding: QUOTED-PRINTABLE Hi,

of course comments are welcome!
And yes, you're right about all of them. we will fix it ASAP.

In other hand, we don't expect to do this plugin official to QEMU. we think it's too specific and it's useless to "normal" qemu user.

By the way,  I'd like ask to mailing list if people think it's g= ood enough to make this work official inside QEMU.

Thanks for suggestions and answers!

Màrius

Johannes Schindelin wrote: 
Hi,

On Wed, 22 Nov 2006, Màrius Montón wrote:

  
Our work on SystemC + QEMU has been published:
http://cephis.uab.es/proj/public/qemu/
    

Great!

A few comments (as you said they are welcome):

- As far as I saw, you use C++, but the code is simple enough to be=
=20
written in C. This is needed by SystemC, correct?

- the c++ compiler is typically called CXX, not CC2, in Makefiles

- your diff contains changes to arm-user/Makefile and likewise for ot=
her=20
targets. These Makefiles are just copies of Makefile.target; you shou=
ld=20
patch only this.

- there are backup files in your patch

- some namings are non-English ("llegir", "escriure"). Please use the=
=20
English terms "read" and "write" instead

- (minor nit) the indentation of hw/pc.c is incorrect

- (minor nit) the file names and function names in QEmu are lower cas=
e=20
("SCLink.c", "SC_init()")

- since the SystemC code is not target specific (or is it?), you coul=
d=20
have it in its own subdirectory, like the audio/ stuff

- this code depends on SystemC being present, right? You should add a=
=20
configure option, and disable this code (including CXX linking) if th=
e=20
option was not passed -- there are probably many more users without t=
he=20
necessary dependencies

- if you want to submit it to the list, you can do so as an attached=
=20
gzipped patch

Ciao,
Dscho

  

_______________________________________________
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/q=
emu-devel

--
Màrius Montón i Macián   <= font color=3D"#00ffff">marius.monton@uab.cat   http://cephis.uab.es
Hardware Engine= er
 Centre de Proto= tips i Solucions Hardware-Software
Dep. Microelectrònica i Sistemes Electrònics
ETSE - Universitat Autònoma de Barcelona (UAB) = 		Phone: +34 = 935 813 534
 Fax: +3= 4 935 813 033
 QC-2090= D. ETSE. Campus UAB.
 080193 Bellaterra
--Boundary_(ID_EeNjQUvEZLQ7EN2O2uVmTw)-- --Boundary_(ID_9Zy87HzGIAWTjw/CGBRpKg) Content-type: text/x-vcard; charset=utf-8; name=marius.monton.vcf Content-transfer-encoding: QUOTED-PRINTABLE Content-disposition: attachment; filename=marius.monton.vcf begin:vcard fn;quoted-printable:M=3DC3=3DA0rius Mont=3DC3=3DB3n n;quoted-printable;quoted-printable:Mont=3DC3=3DB3n;M=3DC3=3DA0rius org;quoted-printable:CEPHIS;Microelectr=3DC3=3DB2nica i Sistemes Elec= tronics adr:Campus de la UAB;;QC-2090D, ETSE;Bellaterra;Barcelona;08193;Spain email;internet:marius.monton@uab.es title:HW Engineer tel;work:+34935813534 tel;fax:+34935813033 x-mozilla-html:TRUE url:http://cephis.uab.es version:2.1 end:vcard --Boundary_(ID_9Zy87HzGIAWTjw/CGBRpKg)--