From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 459D0C05027 for ; Mon, 23 Jan 2023 08:13:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJrwU-0008LQ-6G; Mon, 23 Jan 2023 03:12:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJrwQ-0008L0-JR for qemu-devel@nongnu.org; Mon, 23 Jan 2023 03:12:34 -0500 Received: from mail.xen0n.name ([115.28.160.31] helo=mailbox.box.xen0n.name) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJrwM-0006ds-VV for qemu-devel@nongnu.org; Mon, 23 Jan 2023 03:12:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1674461545; bh=T2bCkTSoHbY+s0SJ93HhkTABSzeTSXqVyclvUPyytGw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=N5gRbpdrAQd4UEHfAKnysjxQ09bA6KkEBaQxch8kkE+YgGqV+qrPTsc4ZxKA88cU7 lIN19QGQ8MYc5Y8HVvHlTK91N8vwL8kenGYLLjc6XpmPhyAsMdbZnjpreP+viVJxgQ 8ijUqB6lOVSS+DqQf3JZvg+m4UrDj2LWlB0IYy0Q= Received: from [192.168.9.172] (unknown [101.88.135.165]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 891316017E; Mon, 23 Jan 2023 16:12:25 +0800 (CST) Message-ID: <4564eb59-8684-de1c-0993-836da46274d9@xen0n.name> Date: Mon, 23 Jan 2023 15:10:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0 Thunderbird/111.0a1 Subject: Re: [PATCH v2 07/10] tcg/loongarch64: Improve setcond expansion Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: git@xen0n.name References: <20230118011123.392823-1-richard.henderson@linaro.org> <20230118011123.392823-8-richard.henderson@linaro.org> From: WANG Xuerui In-Reply-To: <20230118011123.392823-8-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=115.28.160.31; envelope-from=i.qemu@xen0n.name; helo=mailbox.box.xen0n.name X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.149, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/18/23 09:11, Richard Henderson wrote: > Split out a helper function, tcg_out_setcond_int, which > does not always produce the complete boolean result, but > returns a set of flags to do so. > > Accept all int32_t as constant input, so that LE/GT can > adjust the constant to LT. > > Signed-off-by: Richard Henderson > --- > tcg/loongarch64/tcg-target.c.inc | 165 +++++++++++++++++++++---------- > 1 file changed, 115 insertions(+), 50 deletions(-) Reviewed-by: WANG Xuerui Thanks!