Re: [PATCH 13/18] include/hw/s390x: Add include files for common IPL structs

[Thomas Huth <thuth@redhat.com>]

On 27/09/2024 02.51, jrossi@linux.ibm.com wrote:
> From: Jared Rossi <jrossi@linux.ibm.com>
> 
> Currently, structures defined in both hw/s390x/ipl.h and pc-bios/s390-ccw/iplb.h
> must be kept in sync, which is prone to error. Instead, create a new directory
> at include/hw/s390x/ipl/ to contain the definitions that must be shared.
> 
> Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
> 
> ---
...
> diff --git a/include/hw/s390x/ipl/qipl.h b/include/hw/s390x/ipl/qipl.h
> new file mode 100644
> index 0000000000..d21a8f91e3
> --- /dev/null
> +++ b/include/hw/s390x/ipl/qipl.h
> @@ -0,0 +1,123 @@
> +/*
> + * S/390 boot structures
> + *
> + * Copyright 2024 IBM Corp.
> + * Author(s): Jared Rossi <jrossi@linux.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or (at
> + * your option) any later version. See the COPYING file in the top-level
> + * directory.
> + */
> +
> +#ifndef S390X_QIPL_H
> +#define S390X_QIPL_H
> +
> +/* Boot Menu flags */
> +#define QIPL_FLAG_BM_OPTS_CMD   0x80
> +#define QIPL_FLAG_BM_OPTS_ZIPL  0x40
> +
> +#define QIPL_ADDRESS  0xcc
> +#define LOADPARM_LEN    8
> +
> +/*
> + * The QEMU IPL Parameters will be stored at absolute address
> + * 204 (0xcc) which means it is 32-bit word aligned but not
> + * double-word aligned. Placement of 64-bit data fields in this
> + * area must account for their alignment needs.
> + * The total size of the struct must never exceed 28 bytes.
> + */
> +struct QemuIplParameters {
> +    uint8_t  qipl_flags;
> +    uint8_t  reserved1[3];
> +    uint64_t reserved2;
> +    uint32_t boot_menu_timeout;
> +    uint8_t  reserved3[12];
> +} QEMU_PACKED;
> +typedef struct QemuIplParameters QemuIplParameters;
> +
> +struct IPLBlockPVComp {
> +    uint64_t tweak_pref;
> +    uint64_t addr;
> +    uint64_t size;
> +}  QEMU_PACKED;

Could you please replace the two spaces in front of QEMU_PACKED with just 
one place? (also in the other affected spots in this file)

Apart from that cosmetic nit:
Reviewed-by: Thomas Huth <thuth@redhat.com>