From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gy8IY-0008TP-Mk for qemu-devel@nongnu.org; Sat, 23 Dec 2006 09:56:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gy8IX-0008Qa-0n for qemu-devel@nongnu.org; Sat, 23 Dec 2006 09:56:30 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gy8IW-0008QH-L2 for qemu-devel@nongnu.org; Sat, 23 Dec 2006 09:56:28 -0500 Received: from [84.96.92.11] (helo=smtp.Neuf.fr) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gy8IW-0003yM-5k for qemu-devel@nongnu.org; Sat, 23 Dec 2006 09:56:28 -0500 Received: from [84.99.204.119] by sp604005mt.gpm.neuf.ld (Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006)) with ESMTP id <0JAQ00MWIESYE661@sp604005mt.gpm.neuf.ld> for qemu-devel@nongnu.org; Sat, 23 Dec 2006 15:55:46 +0100 (CET) Date: Sat, 23 Dec 2006 15:57:25 +0100 From: Fabrice Bellard Subject: Re: [Qemu-devel] qemu elf_ops.h loader.c hw/mips_r4k.c target-ar... In-reply-to: Message-id: <458D43D5.6060001@bellard.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7BIT References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Your change in elf_ops.h regarding the labels fail1 and fail2 is not necessary: qemu_free(NULL) is perfectly valid and there are many pieces of code relying on it. Please revert. Regards, Fabrice. Thiemo Seufer wrote: > CVSROOT: /sources/qemu > Module name: qemu > Changes by: Thiemo Seufer 06/12/23 14:18:40 > > Modified files: > . : elf_ops.h loader.c > hw : mips_r4k.c > target-arm : cpu.h > target-i386 : cpu.h > target-m68k : cpu.h > target-mips : cpu.h > target-ppc : cpu.h > target-sh4 : cpu.h > target-sparc : cpu.h > > Log message: > Check ELF binaries for machine type and endianness. > > CVSWeb URLs: > http://cvs.savannah.gnu.org/viewcvs/qemu/elf_ops.h?cvsroot=qemu&r1=1.3&r2=1.4 > http://cvs.savannah.gnu.org/viewcvs/qemu/loader.c?cvsroot=qemu&r1=1.3&r2=1.4 > http://cvs.savannah.gnu.org/viewcvs/qemu/hw/mips_r4k.c?cvsroot=qemu&r1=1.27&r2=1.28 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-arm/cpu.h?cvsroot=qemu&r1=1.17&r2=1.18 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/cpu.h?cvsroot=qemu&r1=1.38&r2=1.39 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-m68k/cpu.h?cvsroot=qemu&r1=1.1&r2=1.2 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-mips/cpu.h?cvsroot=qemu&r1=1.15&r2=1.16 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/cpu.h?cvsroot=qemu&r1=1.23&r2=1.24 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-sh4/cpu.h?cvsroot=qemu&r1=1.3&r2=1.4 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-sparc/cpu.h?cvsroot=qemu&r1=1.25&r2=1.26 > > > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel > >