From: Jonathan Phenix <jonathan.phenix@videotron.ca>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] factor out commonly used scancode translation table
Date: Thu, 04 Jan 2007 12:52:56 -0500 [thread overview]
Message-ID: <459D3EF8.4030101@videotron.ca> (raw)
In-Reply-To: <20070104172914.GG28746@aon.at>
Bernhard Fischer wrote:
> Hi,
>
> The attached patch moves the x_keycode_to_pc_keycode LUT from sdl.c into
> an x_keycode.c. This struct is also used by the GGI backend (that is not
> yet merged ¹).
>
> Comments?
>
How it is done right now, each time x_keycode.c is included, you will
end up with an extra copy in the final executable. Perhaps that simply
keeping the LUT in sdl.c but removing the 'static' keyword from it and
creating a sdl.h file with the statement:
extern const uint8_t *x_keycode_to_pc_keycode;
would be a better idea. Including a header file is more clean than
including a C file as well.
> Please apply.
>
> ¹)
> http://members.aon.at/berny_f/qemu/qemu-HEAD.ggi-2.2.x-04c-20070104.diff
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>
next prev parent reply other threads:[~2007-01-04 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-04 17:29 [Qemu-devel] [patch] factor out commonly used scancode translation table Bernhard Fischer
2007-01-04 17:52 ` Jonathan Phenix [this message]
2007-01-04 18:01 ` Bernhard Fischer
2007-01-04 18:10 ` Thiemo Seufer
2007-01-04 18:52 ` Bernhard Fischer
2007-01-04 19:06 ` Anthony Liguori
2007-01-14 22:58 ` Rob Landley
2007-01-16 20:59 ` Bernhard Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459D3EF8.4030101@videotron.ca \
--to=jonathan.phenix@videotron.ca \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).