From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H2Wmc-0007XA-3F for qemu-devel@nongnu.org; Thu, 04 Jan 2007 12:53:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H2Wma-0007WS-Dl for qemu-devel@nongnu.org; Thu, 04 Jan 2007 12:53:41 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H2Wma-0007WP-8J for qemu-devel@nongnu.org; Thu, 04 Jan 2007 12:53:40 -0500 Received: from [24.201.245.36] (helo=relais.videotron.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1H2WmZ-0004Xk-Sp for qemu-devel@nongnu.org; Thu, 04 Jan 2007 12:53:40 -0500 Received: from [192.168.0.253] ([74.56.26.189]) by VL-MH-MR002.ip.videotron.ca (Sun Java System Messaging Server 6.2-2.05 (built Apr 28 2005)) with ESMTP id <0JBC004C1V08C4H0@VL-MH-MR002.ip.videotron.ca> for qemu-devel@nongnu.org; Thu, 04 Jan 2007 12:52:57 -0500 (EST) Date: Thu, 04 Jan 2007 12:52:56 -0500 From: Jonathan Phenix Subject: Re: [Qemu-devel] [patch] factor out commonly used scancode translation table In-reply-to: <20070104172914.GG28746@aon.at> Message-id: <459D3EF8.4030101@videotron.ca> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <20070104172914.GG28746@aon.at> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Bernhard Fischer wrote: > Hi, > > The attached patch moves the x_keycode_to_pc_keycode LUT from sdl.c= into > an x_keycode.c. This struct is also used by the GGI backend (that i= s not > yet merged =B9). > > Comments? > =20 How it is done right now, each time x_keycode.c is included, you will= =20 end up with an extra copy in the final executable. Perhaps that simpl= y=20 keeping the LUT in sdl.c but removing the 'static' keyword from it an= d=20 creating a sdl.h file with the statement: extern const uint8_t *x_keycode_to_pc_keycode; would be a better idea. Including a header file is more clean than= =20 including a C file as well. > Please apply. > > =B9) > http://members.aon.at/berny_f/qemu/qemu-HEAD.ggi-2.2.x-04c-20070104= .diff > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel > =20