From: Thomas Huth <thuth@redhat.com>
To: Pan Nengyuan <pannengyuan@huawei.com>, qemu-devel@nongnu.org
Cc: zhang.zhanghailiang@huawei.com, quintela@redhat.com,
qemu-trivial@nongnu.org, f4bug@amsat.org, dgilbert@redhat.com,
eric.auger@redhat.com, kuhn.chenqun@huawei.com
Subject: Re: [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node
Date: Thu, 10 Sep 2020 06:49:32 +0200 [thread overview]
Message-ID: <459acccd-f501-865f-03cd-796cfb2a4502@redhat.com> (raw)
In-Reply-To: <20200910023818.11880-1-pannengyuan@huawei.com>
On 10/09/2020 04.38, Pan Nengyuan wrote:
> 'str' is not used in match_interval_mapping_node(), remove it.
>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
> tests/test-vmstate.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f8de709a0b..1c763015d0 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key,
> TestGTreeMapping *map_a, *map_b;
> TestGTreeInterval *a, *b;
> struct match_node_data *d = (struct match_node_data *)data;
> - char *str = g_strdup_printf("dest");
> -
> - g_free(str);
> a = (TestGTreeInterval *)key;
> b = (TestGTreeInterval *)d->key;
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-09-10 4:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 2:38 [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node Pan Nengyuan
2020-09-10 4:48 ` Li Qiang
2020-09-10 4:49 ` Thomas Huth [this message]
2020-09-10 6:55 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459acccd-f501-865f-03cd-796cfb2a4502@redhat.com \
--to=thuth@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eric.auger@redhat.com \
--cc=f4bug@amsat.org \
--cc=kuhn.chenqun@huawei.com \
--cc=pannengyuan@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).