* [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node
@ 2020-09-10 2:38 Pan Nengyuan
2020-09-10 4:48 ` Li Qiang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pan Nengyuan @ 2020-09-10 2:38 UTC (permalink / raw)
To: qemu-devel
Cc: thuth, zhang.zhanghailiang, quintela, qemu-trivial, Pan Nengyuan,
f4bug, dgilbert, eric.auger, kuhn.chenqun
'str' is not used in match_interval_mapping_node(), remove it.
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
---
tests/test-vmstate.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index f8de709a0b..1c763015d0 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key,
TestGTreeMapping *map_a, *map_b;
TestGTreeInterval *a, *b;
struct match_node_data *d = (struct match_node_data *)data;
- char *str = g_strdup_printf("dest");
-
- g_free(str);
a = (TestGTreeInterval *)key;
b = (TestGTreeInterval *)d->key;
--
2.21.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node
2020-09-10 2:38 [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node Pan Nengyuan
@ 2020-09-10 4:48 ` Li Qiang
2020-09-10 4:49 ` Thomas Huth
2020-09-10 6:55 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Li Qiang @ 2020-09-10 4:48 UTC (permalink / raw)
To: Pan Nengyuan
Cc: Thomas Huth, zhanghailiang, Juan Quintela, qemu-trivial,
Qemu Developers, Philippe Mathieu-Daudé, Auger Eric,
Chen Qun, Dr. David Alan Gilbert
Pan Nengyuan <pannengyuan@huawei.com> 于2020年9月10日周四 上午10:39写道：
>
> 'str' is not used in match_interval_mapping_node(), remove it.
>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> tests/test-vmstate.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f8de709a0b..1c763015d0 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key,
> TestGTreeMapping *map_a, *map_b;
> TestGTreeInterval *a, *b;
> struct match_node_data *d = (struct match_node_data *)data;
> - char *str = g_strdup_printf("dest");
> -
> - g_free(str);
> a = (TestGTreeInterval *)key;
> b = (TestGTreeInterval *)d->key;
>
> --
> 2.21.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node
2020-09-10 2:38 [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node Pan Nengyuan
2020-09-10 4:48 ` Li Qiang
@ 2020-09-10 4:49 ` Thomas Huth
2020-09-10 6:55 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2020-09-10 4:49 UTC (permalink / raw)
To: Pan Nengyuan, qemu-devel
Cc: zhang.zhanghailiang, quintela, qemu-trivial, f4bug, dgilbert,
eric.auger, kuhn.chenqun
On 10/09/2020 04.38, Pan Nengyuan wrote:
> 'str' is not used in match_interval_mapping_node(), remove it.
>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
> tests/test-vmstate.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f8de709a0b..1c763015d0 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key,
> TestGTreeMapping *map_a, *map_b;
> TestGTreeInterval *a, *b;
> struct match_node_data *d = (struct match_node_data *)data;
> - char *str = g_strdup_printf("dest");
> -
> - g_free(str);
> a = (TestGTreeInterval *)key;
> b = (TestGTreeInterval *)d->key;
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node
2020-09-10 2:38 [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node Pan Nengyuan
2020-09-10 4:48 ` Li Qiang
2020-09-10 4:49 ` Thomas Huth
@ 2020-09-10 6:55 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-09-10 6:55 UTC (permalink / raw)
To: Pan Nengyuan, qemu-devel
Cc: thuth, zhang.zhanghailiang, quintela, qemu-trivial, f4bug,
dgilbert, eric.auger, kuhn.chenqun
Le 10/09/2020 à 04:38, Pan Nengyuan a écrit :
> 'str' is not used in match_interval_mapping_node(), remove it.
>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
> tests/test-vmstate.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f8de709a0b..1c763015d0 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -1055,9 +1055,6 @@ static gboolean match_interval_mapping_node(gpointer key,
> TestGTreeMapping *map_a, *map_b;
> TestGTreeInterval *a, *b;
> struct match_node_data *d = (struct match_node_data *)data;
> - char *str = g_strdup_printf("dest");
> -
> - g_free(str);
> a = (TestGTreeInterval *)key;
> b = (TestGTreeInterval *)d->key;
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-10 6:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-10 2:38 [PATCH] test-vmstate: remove unnecessary code in match_interval_mapping_node Pan Nengyuan
2020-09-10 4:48 ` Li Qiang
2020-09-10 4:49 ` Thomas Huth
2020-09-10 6:55 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).