* [PULL 0/2] vfio-user queue @ 2023-06-07 14:38 Jagannathan Raman 2023-06-07 14:38 ` [PULL 1/2] vfio-user: update comments Jagannathan Raman ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Jagannathan Raman @ 2023-06-07 14:38 UTC (permalink / raw) To: qemu-devel The following changes since commit f5e6786de4815751b0a3d2235c760361f228ea48: Merge tag 'pull-target-arm-20230606' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-06-06 12:11:34 -0700) are available in the Git repository at: https://gitlab.com/jraman/qemu.git tags/pull-vfio-user-20230607 for you to fetch changes up to 7771e8b86335968ee46538d1afd44246e7a062bc: docs: fix multi-process QEMU documentation (2023-06-07 10:21:53 -0400) ---------------------------------------------------------------- vfio-user: Fix the documentation for vfio-user and multi-process QEMU Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> ---------------------------------------------------------------- Jagannathan Raman (2): vfio-user: update comments docs: fix multi-process QEMU documentation docs/system/multi-process.rst | 2 +- hw/remote/vfio-user-obj.c | 14 +++++++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PULL 1/2] vfio-user: update comments 2023-06-07 14:38 [PULL 0/2] vfio-user queue Jagannathan Raman @ 2023-06-07 14:38 ` Jagannathan Raman 2023-06-07 14:38 ` [PULL 2/2] docs: fix multi-process QEMU documentation Jagannathan Raman 2023-06-07 18:42 ` [PULL 0/2] vfio-user queue Richard Henderson 2 siblings, 0 replies; 4+ messages in thread From: Jagannathan Raman @ 2023-06-07 14:38 UTC (permalink / raw) To: qemu-devel Clarify the behavior of TYPE_VFU_OBJECT when TYPE_REMOTE_MACHINE enables the auto-shutdown property. Also, add notes to VFU_OBJECT_ERROR. Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> --- hw/remote/vfio-user-obj.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c index 88ffafc73e56..8b10c32a3c6e 100644 --- a/hw/remote/vfio-user-obj.c +++ b/hw/remote/vfio-user-obj.c @@ -30,6 +30,11 @@ * * notes - x-vfio-user-server could block IO and monitor during the * initialization phase. + * + * When x-remote machine has the auto-shutdown property + * enabled (default), x-vfio-user-server terminates after the last + * client disconnects. Otherwise, it will continue running until + * explicitly killed. */ #include "qemu/osdep.h" @@ -61,9 +66,12 @@ OBJECT_DECLARE_TYPE(VfuObject, VfuObjectClass, VFU_OBJECT) /** - * VFU_OBJECT_ERROR - reports an error message. If auto_shutdown - * is set, it aborts the machine on error. Otherwise, it logs an - * error message without aborting. + * VFU_OBJECT_ERROR - reports an error message. + * + * If auto_shutdown is set, it aborts the machine on error. Otherwise, + * it logs an error message without aborting. auto_shutdown is disabled + * when the server serves clients from multiple VMs; as such, an error + * from one VM shouldn't be able to disrupt other VM's services. */ #define VFU_OBJECT_ERROR(o, fmt, ...) \ { \ -- 2.20.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PULL 2/2] docs: fix multi-process QEMU documentation 2023-06-07 14:38 [PULL 0/2] vfio-user queue Jagannathan Raman 2023-06-07 14:38 ` [PULL 1/2] vfio-user: update comments Jagannathan Raman @ 2023-06-07 14:38 ` Jagannathan Raman 2023-06-07 18:42 ` [PULL 0/2] vfio-user queue Richard Henderson 2 siblings, 0 replies; 4+ messages in thread From: Jagannathan Raman @ 2023-06-07 14:38 UTC (permalink / raw) To: qemu-devel Fix a typo in the system documentation for multi-process QEMU. Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> --- docs/system/multi-process.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/multi-process.rst b/docs/system/multi-process.rst index 16f0352416bc..2008a6780953 100644 --- a/docs/system/multi-process.rst +++ b/docs/system/multi-process.rst @@ -4,7 +4,7 @@ Multi-process QEMU ================== This document describes how to configure and use multi-process qemu. -For the design document refer to docs/devel/qemu-multiprocess. +For the design document refer to docs/devel/multi-process.rst. 1) Configuration ---------------- -- 2.20.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PULL 0/2] vfio-user queue 2023-06-07 14:38 [PULL 0/2] vfio-user queue Jagannathan Raman 2023-06-07 14:38 ` [PULL 1/2] vfio-user: update comments Jagannathan Raman 2023-06-07 14:38 ` [PULL 2/2] docs: fix multi-process QEMU documentation Jagannathan Raman @ 2023-06-07 18:42 ` Richard Henderson 2 siblings, 0 replies; 4+ messages in thread From: Richard Henderson @ 2023-06-07 18:42 UTC (permalink / raw) To: Jagannathan Raman, qemu-devel On 6/7/23 07:38, Jagannathan Raman wrote: > The following changes since commit f5e6786de4815751b0a3d2235c760361f228ea48: > > Merge tag 'pull-target-arm-20230606' ofhttps://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-06-06 12:11:34 -0700) > > are available in the Git repository at: > > https://gitlab.com/jraman/qemu.git tags/pull-vfio-user-20230607 > > for you to fetch changes up to 7771e8b86335968ee46538d1afd44246e7a062bc: > > docs: fix multi-process QEMU documentation (2023-06-07 10:21:53 -0400) > > ---------------------------------------------------------------- > vfio-user: Fix the documentation for vfio-user and multi-process QEMU > > Signed-off-by: Jagannathan Raman<jag.raman@oracle.com> Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate. r~ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-07 18:43 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-06-07 14:38 [PULL 0/2] vfio-user queue Jagannathan Raman 2023-06-07 14:38 ` [PULL 1/2] vfio-user: update comments Jagannathan Raman 2023-06-07 14:38 ` [PULL 2/2] docs: fix multi-process QEMU documentation Jagannathan Raman 2023-06-07 18:42 ` [PULL 0/2] vfio-user queue Richard Henderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).