qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] better handling of removal in	IOHandlerRecord list
Date: Thu, 11 Jan 2007 20:58:24 +0100	[thread overview]
Message-ID: <45A696E0.70306@bellard.org> (raw)
In-Reply-To: <1168527610.4765.12.camel@bibi>

I think a more complete patch is needed to fully correct the problem.

Regards,

Fabrice.

jerome Arbez-Gindre wrote:
> On Thu, 2007-01-11 at 14:56 +0100, jerome Arbez-Gindre wrote:
> 
>>On Wed, 2007-01-10 at 17:34 +0100, jerome Arbez-Gindre wrote:
>>
>>>Hi,
>>>
>>>by a call to qemu_set_fd_handler(fd,NULL,NULL,NULL) in the fd_read
>>>callback, I have generated a "Segmentation fault" in vl.c.
>>>
>>>My solution is not very smart... but it is very simple.
>>
>>I reply to myself because I did not sleep last night:
>>
>>Here is the fix without the double IOHandlerRecord list iteration.
> 
> 
> Here is a little fix to handle the case when a IOHandler removes an
> other IOHandler.
> 
> --- vl.c.mine	2007-01-11 15:06:47.000000000 +0100
> +++ vl.c	2007-01-11 15:27:27.000000000 +0100
> @@ -5912,11 +5912,13 @@
>          pioh = &first_io_handler ;
>          for(ioh = first_io_handler; ioh != NULL; ioh = ioh_next) {
>              ioh_next = ioh->next;
> -            if (FD_ISSET(ioh->fd, &rfds)) {
> +            /* ioh->fd_read could have been set to null by an other
> +               IOHandlerRecord callback */
> +            if (ioh->fd_read && FD_ISSET(ioh->fd, &rfds)) {
>                  ioh->fd_read(ioh->opaque);
>              }
>              /* ioh->fd_write could have been set to null */
> -            if ((ioh->fd_write) && (FD_ISSET(ioh->fd, &wfds))) {
> +            if (ioh->fd_write && FD_ISSET(ioh->fd, &wfds)) {
>                  ioh->fd_write(ioh->opaque);
>              }
>              /* the ioh could have been supressed */
> 
> 
> 
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
> 
> 

      reply	other threads:[~2007-01-11 20:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-10 16:34 [Qemu-devel] [PATCH] better handling of removal in IOHandlerRecord list jerome Arbez-Gindre
2007-01-11 13:56 ` jerome Arbez-Gindre
2007-01-11 15:00   ` jerome Arbez-Gindre
2007-01-11 19:58     ` Fabrice Bellard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45A696E0.70306@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).