From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H56GB-0007zM-DQ for qemu-devel@nongnu.org; Thu, 11 Jan 2007 15:10:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H56GA-0007z0-RP for qemu-devel@nongnu.org; Thu, 11 Jan 2007 15:10:51 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H56GA-0007yr-LQ for qemu-devel@nongnu.org; Thu, 11 Jan 2007 15:10:50 -0500 Received: from [84.96.92.60] (helo=Smtp.neuf.fr) by monty-python.gnu.org with esmtp (Exim 4.52) id 1H56GA-0007nn-B3 for qemu-devel@nongnu.org; Thu, 11 Jan 2007 15:10:50 -0500 Received: from [86.73.70.95] by sp604001mt.gpm.neuf.ld (Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006)) with ESMTP id <0JBP00CC2ZLG11W0@sp604001mt.gpm.neuf.ld> for qemu-devel@nongnu.org; Thu, 11 Jan 2007 21:00:52 +0100 (CET) Date: Thu, 11 Jan 2007 21:00:58 +0100 From: Fabrice Bellard Subject: Re: [Qemu-devel] [PATCH] Change the 82371SB PCI-to-ISA bridge into a82371EB In-reply-to: <20070110005428.GA12917@farad.aurel32.net> Message-id: <45A6977A.2070409@bellard.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7BIT References: <20070109154451.GC5603@farad.aurel32.net> <3c9801c73418$7fe43470$e90d11ac@spb.in.rosprint.ru> <20070110005428.GA12917@farad.aurel32.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org I would prefer to keep the PIIX3 for the PC until the PIIX4 is more tested (and implemented !). I would accept having both PIIX3 and PIIX4 (a flag could suffice at the init). Regards, Fabrice. Aurelien Jarno wrote: > On Tue, Jan 09, 2007 at 09:03:01PM +0300, Alexander Voropay wrote: > >>"Aurelien Jarno" wrote: >> >> >>>This patch changes the 82371SB PCI-to-ISA bridge into a 82371EB. >>> >>>Note that the ACPI controller >>>implemented in QEMU is already a 82371EB. >> >>Shouldn't we also change all "piix3" names to "piix4" ? >> >>[qemu]$ find . -type f | xargs grep "piix3" | wc -l >>18 >> >> > > > You are probably right for this device, but note that the USB and the > IDE controller are still PIIX3. And this corresponds to the emulated > devices. Ideally it would be nice to also change them into PIIX4 by > implementing the missing features. Some of the missing features are > really cool, like DMA support in IDE controller. > > Please find below a new patch that also changes the name of the ISA > bridge to piix4. That introduces a sequence in the patches, it needs to > be applied after the patch "devfn number for the PIIX3 southbridge". > > Bye, > Aurelien > > > > This patch changes the 82371SB PCI-to-ISA bridge into a 82371EB. There > are no differences in the implementation, but the Malta platform needs > this device as there are some PCI fixup in the Linux kernel. > > This should be supported without problem by the i386 and x86_64 targets > as there is no standard PC hardware. Note that the ACPI controller > implemented in QEMU is already a 82371EB. > [...]