qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation
Date: Tue, 23 Jan 2007 22:49:59 +0100	[thread overview]
Message-ID: <45B68307.9090509@bellard.org> (raw)
In-Reply-To: <c1bf1cf0701231326s42e3c404y4fbf66abd7e2ea30@mail.gmail.com>

Ed Swierk wrote:
> The attached patch adds SMBus host support to the emulated PIIX4 power
> management device (acpi.c), and adds an emulated serial EEPROM device
> accessible via the SMBus interface.
> 
> I tried to follow the Intel 82371AB spec for the SMBus support; the
> interface should be generic enough to implement a variety of
> SMBus-compliant devices.
> 
> The EEPROM device can use a file for persistent storage
> (smbus_eeprom.bin in the BIOS directory). If this file does not exist,
> a temporary buffer is used instead.
> 
> I tested the devices with Linux using the i2c-piix4 host driver and
> the eeprom chip driver. I have no idea what will happen on other OSes.
> 
> Comments and suggestions welcome.
 > [...]

OK, but avoid using mmap() in the device code. Moreover, files in the 
BIOS directory are not writable.

Regards,

Fabrice.

  reply	other threads:[~2007-01-23 22:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-23 21:26 [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation Ed Swierk
2007-01-23 21:49 ` Fabrice Bellard [this message]
2007-01-23 22:30   ` Ed Swierk
2007-01-23 23:22   ` Ed Swierk
2007-01-24  1:55     ` Ed Swierk
2007-01-24 20:33     ` Fabrice Bellard
2007-01-31 12:07     ` Thiemo Seufer
2007-01-31 17:16       ` Ed Swierk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45B68307.9090509@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).