From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1H9p6L-0000ui-Du
	for qemu-devel@nongnu.org; Wed, 24 Jan 2007 15:52:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1H9p6K-0000sz-3i
	for qemu-devel@nongnu.org; Wed, 24 Jan 2007 15:52:13 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1H9p6J-0000st-UI
	for qemu-devel@nongnu.org; Wed, 24 Jan 2007 15:52:11 -0500
Received: from sp604003mt.neufgp.fr ([84.96.92.56] helo=smTp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1H9p6J-0002Pn-9Q
	for qemu-devel@nongnu.org; Wed, 24 Jan 2007 15:52:11 -0500
Received: from [84.102.211.179] by sp604003mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0JCE00H8V3YGPQD1@sp604003mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Wed, 24 Jan 2007 21:37:28 +0100 (CET)
Date: Wed, 24 Jan 2007 21:37:44 +0100
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] New multiple snapshot support for VMDK.
In-reply-to: <64F9B87B6B770947A9F8391472E032160A167F52@ehost011-8.exch011.intermedia.net>
Message-id: <45B7C398.1000602@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: QUOTED-PRINTABLE
References: <64F9B87B6B770947A9F8391472E032160A167F52@ehost011-8.exch011.intermedia.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

Your patch seems OK to me.

Fabrice.

Igor Lvovsky wrote:
>=20
>=20
>    Hi Fabrice,
>=20
> What are you think about this patch?
>=20
> Are you have a comments?
>=20
> If you accept it, I'll try to fix the race condition on snapshot wr=
iting.
>=20
>                       =20
>=20
>                         Regards
>=20
>                                     Igor Lvovsky
>=20
> =20
>=20
>           =20
>=20
> =20
>=20
> =20
>=20
> =20
>=20
> =20
>=20
> * From: * qemu-devel-bounces+igor.lvovsky=3Dqumranet.com@nongnu.org=
=20
> [mailto:qemu-devel-bounces+igor.lvovsky=3Dqumranet.com@nongnu.org] =
*On=20
> Behalf Of * Igor Lvovsky
> *Sent:* Monday, January 15, 2007 4:51 PM
> *To:* qemu-devel@nongnu.org
> *Subject:* [Qemu-devel] New multiple snapshot support for VMDK.
>=20
> =20
>=20
>    Hi all,
>=20
> It's the new patch for the multiple snapshot support for the VMDK f=
ormat.
>=20
> I rewrote the previous one according to the new multiple snapshots=
=20
> concept, introduced by Fabrice.
>=20
> =20
>=20
> The snapshots can be created with standard way:
>=20
> =20
>=20
> qemu-img create =E2=80=93b base-image.vmdk =E2=80=93f vmdk snapshot=
-img-001.vmdk
>=20
> =20
>=20
> We can create the snapshots chain in this way.
>=20
> The patch include also the 'CID' protection that defined by the VMD=
K=20
> format.
>=20
> The CID is a value updated on the first write every time the virtua=
l=20
> disk is opened.
>=20
> =20
>=20
>  P.S. Fabrice, I used the bdrv_pread() and bdrv_pwrite(), as you ad=
vised=20
> me.
>=20
> =20
>=20
>             Regards,
>=20
>                         Igor Lvovsky
>=20
> =20
>=20
> =20
>=20
> =20
>=20
> =20
>=20
>=20
> -------------------------------------------------------------------=
-----
>=20
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel