From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HCqqu-0004cy-HU
	for qemu-devel@nongnu.org; Fri, 02 Feb 2007 00:20:48 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HCqqs-0004cm-7f
	for qemu-devel@nongnu.org; Fri, 02 Feb 2007 00:20:47 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HCqqs-0004cj-15
	for qemu-devel@nongnu.org; Fri, 02 Feb 2007 00:20:46 -0500
Received: from nlpi029.sbcis.sbc.com ([207.115.36.58])
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1HCqqr-0001ci-Qt
	for qemu-devel@nongnu.org; Fri, 02 Feb 2007 00:20:45 -0500
Received: from mail.hoko.org (adsl-76-212-56-81.dsl.klmzmi.sbcglobal.net
	[76.212.56.81])
	by nlpi029.sbcis.sbc.com (8.13.8 out.dk.spool/8.13.8) with ESMTP id
	l125K6Kg031787
	for <qemu-devel@nongnu.org>; Thu, 1 Feb 2007 23:20:06 -0600
Received: from [192.168.2.254] (lithium.hoko.org [192.168.2.254])
	by mail.hoko.org (Postfix) with ESMTP id 422BF1B2CFE6
	for <qemu-devel@nongnu.org>; Fri,  2 Feb 2007 00:20:43 -0500 (EST)
Message-ID: <45C2CA29.1010107@hoko.org>
Date: Fri, 02 Feb 2007 00:20:41 -0500
From: Scott Oom <other+qemudev@hoko.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------080302070803080808090206"
Subject: [Qemu-devel] [PATCH] ARM MMU translation - fix small (4k) page
	access
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is a multi-part message in MIME format.
--------------080302070803080808090206
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hello,
Found a problem when using small pages and getting permission faults.
This patch corrects the decoding of access permissions for small pages
on ARM, was just off by 2 bits.

-Scott

--------------080302070803080808090206
Content-Type: text/x-patch;
 name="qemu-arm-mmu-smallpages-access.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="qemu-arm-mmu-smallpages-access.patch"

Index: target-arm/helper.c
===================================================================
RCS file: /sources/qemu/qemu/target-arm/helper.c,v
retrieving revision 1.8
diff -u -3 -p -r1.8 helper.c
--- target-arm/helper.c	20 Jan 2007 17:12:09 -0000	1.8
+++ target-arm/helper.c	2 Feb 2007 05:12:03 -0000
@@ -338,7 +338,7 @@ static int get_phys_addr(CPUState *env, 
                 break;
             case 2: /* 4k page.  */
                 phys_addr = (desc & 0xfffff000) | (address & 0xfff);
-                ap = (desc >> (4 + ((address >> 13) & 6))) & 3;
+                ap = (desc >> (4 + ((address >> 11) & 6))) & 3; /* SRO */
                 break;
             case 3: /* 1k page.  */
                 if (type == 1) {

--------------080302070803080808090206--