From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HDqix-0007Tl-E0
	for qemu-devel@nongnu.org; Sun, 04 Feb 2007 18:24:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HDqiu-0007TY-Jq
	for qemu-devel@nongnu.org; Sun, 04 Feb 2007 18:24:42 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HDqiu-0007TU-DW
	for qemu-devel@nongnu.org; Sun, 04 Feb 2007 18:24:40 -0500
Received: from sp604005mt.neufgp.fr ([84.96.92.11] helo=smtp.Neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1HDqit-0006fy-Tx
	for qemu-devel@nongnu.org; Sun, 04 Feb 2007 18:24:40 -0500
Received: from [84.102.211.102] by sp604005mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0JCY001X3P111EI1@sp604005mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Mon, 05 Feb 2007 00:24:37 +0100 (CET)
Date: Mon, 05 Feb 2007 00:25:00 +0100
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH] parport EPP support for Linux
In-reply-to: <9cfa10eb0702041236x12b69e2ai269f9a79b6b344f2@mail.gmail.com>
Message-id: <45C66B4C.3020008@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii; format=flowed
Content-transfer-encoding: 7BIT
References: <9cfa10eb0702041236x12b69e2ai269f9a79b6b344f2@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Marko Kohtala wrote:
> Hi.
> 
> With the attached patch I am able to use Kodak Advantix FD 300 APS
> scanner from Win98 when hosted under Linux ix86. It adds EPP support
> and fixes some register bits to match real hw so port identification
> works better.
> 
> I tried to separate the linux dependencies with #ifdef __linux__, but
> can not test this does not break compilation for other ports of qemu.
> 
> Suggestions are welcome, but I also welcome you to make the
> enhancements yourself. This is good enough for me.
> 
> I hope it is good enough for inclusion in Qemu. It applies and was
> tested against current CVS.

I don't understand why you need a #ifdef __linux__ in parallel.c. 
Normally, the qemu character device should suffice to do the appropriate 
abstraction.

Regards,

Fabrice.