From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HNuEy-0004OF-Dh
	for qemu-devel@nongnu.org; Sun, 04 Mar 2007 12:11:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HNuEw-0004ML-SS
	for qemu-devel@nongnu.org; Sun, 04 Mar 2007 12:11:20 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HNuEw-0004MC-Pw
	for qemu-devel@nongnu.org; Sun, 04 Mar 2007 12:11:18 -0500
Received: from wx-out-0506.google.com ([66.249.82.225])
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1HNuEw-0002kC-G0
	for qemu-devel@nongnu.org; Sun, 04 Mar 2007 12:11:18 -0500
Received: by wx-out-0506.google.com with SMTP id i30so2106632wxd
	for <qemu-devel@nongnu.org>; Sun, 04 Mar 2007 09:11:17 -0800 (PST)
Message-ID: <45EAFDB3.7060403@codemonkey.ws>
Date: Sun, 04 Mar 2007 11:11:15 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Add -name option
References: <45EA38D2.7050903@codemonkey.ws> <45EA91BD.8030405@qumranet.com>
In-Reply-To: <45EA91BD.8030405@qumranet.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Avi Kivity wrote:
> Anthony Liguori wrote:
>> This option helps differentiate between guests when running more than 
>> one instance of QEMU.  It adds a string to the SDL window title and 
>> to the VNC server title.
>>
>> Having a name associated with a guest is also terribly useful for 
>> management tools as it gives a standard way to identify guests to the 
>> user.
>>
>>  
>> -    vnc_write_u32(vs, 4);        -    vnc_write(vs, "QEMU", 4);
>> +    if (qemu_name) +    size = snprintf(buf, sizeof(buf), "QEMU 
>> (%s)", qemu_name);
>> +    else
>> +    size = snprintf(buf, sizeof(buf), "QEMU");
>> +
>
> Perhaps in the modern style:
>
>    snprintf("%s - QEMU", sizeof, qemu_name)

So right now we have:

QEMU
QEMU - Press Ctrl+Alt to exit grab

My patch would add:

QEMU (WinXP Home)
QEMU (WinXP Home) - Press Ctrl+Alt to exit grab

You're suggesting:

WinXP Home - QEMU
WinXP Home - QEMU - Press Ctrl+Alt to exit grab

I like yours for the first title but the SDL grab version seems a little 
strange.  That's why I stuck it in ()s in the first place.

Anyone else have ideas?

Regards,

Anthony Liguori

> ?
>