qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Julian Seward <jseward@acm.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Reducing X communication bandwidth, take 2
Date: Fri, 16 Mar 2007 16:09:14 -0500	[thread overview]
Message-ID: <45FB077A.3080407@codemonkey.ws> (raw)
In-Reply-To: <200703162053.02198.jseward@acm.org>

Julian Seward wrote:
> On Friday 16 March 2007 18:40, Anthony Liguori wrote:
>   
>> Hi Julian,
>>
>> Julian Seward wrote:
>>     
>>> Here is a somewhat revised version of a patch I first made nearly
>>> three years ago.  The original thread is
>>>
>>> http://lists.gnu.org/archive/html/qemu-devel/2004-07/msg00263.html
>>>
>>> It still uses a shadow frame buffer.  Fabrice mentioned this is not
>>> necessary
>>>       
>> I thought about this a little and here's what I came up with.
>>
>> I think we could change vga_draw_line* so that as part of the drawing
>> process, it compared the newly generated pixel with the previous pixel
>> value and returned back the min, max x-coordinate that changed.
>>
>> Since we tend to only extend the vertical dirty range by a couple
>> pixels, this should be a relatively cheap way of reducing the size of
>> the update region.
>>     
>
> Sounds plausible - having said that, I have no familiarity with the VGA
> code.  Also sounds like a cleaner solution than mine.
>
> Is there something which guarantees that the vertical dirty range only
> overshoots by some small number of pixels?

Even at a relatively low resolution (640 x 480 @ 16 bit), a page will 
span only three rows so one dirty page cannot dirty more than 5 vertical 
pixels.

>   (thinking more about it ..
> it doesn't matter - finding min/max that changed for each line will also
> make it possible to identify the vertical limits of the change).
>   

This is also true.

> Will this work also for the CL542x adaptor?  (Does that fall in the category
> of vga?)  My current hack works for with/without -std-vga and I think 
> that's because it lives "underneath" both, in the connection to SDL.
>   

Each adapter will have to do it's own minimization but that's sort of 
the write thing anyway IMHO.  How granular each update is really only 
depends on the adapter.  For instance, the VMware adapter really 
shouldn't need to do any minimization at all.

Regards,

Anthony Liguori

> J
>
>   

  reply	other threads:[~2007-03-16 21:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-14  1:52 [Qemu-devel] [PATCH] Reducing X communication bandwidth, take 2 Julian Seward
2007-03-14  3:39 ` Anthony Liguori
2007-03-14  4:57   ` Mark Williamson
2007-03-14 10:53     ` Julian Seward
2007-03-14 12:29       ` Johannes Schindelin
2007-03-16 18:40 ` Anthony Liguori
2007-03-16 20:53   ` Julian Seward
2007-03-16 21:09     ` Anthony Liguori [this message]
2007-03-16 21:38       ` Paul Brook
2007-03-19 16:07         ` [Qemu-devel] " Brian Johnson
2007-03-25 17:22           ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FB077A.3080407@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jseward@acm.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).