From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btvXu-0002Pp-Oc for qemu-devel@nongnu.org; Tue, 11 Oct 2016 07:48:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btvXp-00037r-MQ for qemu-devel@nongnu.org; Tue, 11 Oct 2016 07:48:33 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58481 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btvXp-00037f-Gn for qemu-devel@nongnu.org; Tue, 11 Oct 2016 07:48:29 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9BBjHaa036584 for ; Tue, 11 Oct 2016 07:48:29 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 260vjv0ghk-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 11 Oct 2016 07:48:28 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 11 Oct 2016 12:48:26 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 293981B08023 for ; Tue, 11 Oct 2016 12:50:25 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9BBmOCl9830794 for ; Tue, 11 Oct 2016 11:48:24 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9BBmO9J007957 for ; Tue, 11 Oct 2016 07:48:24 -0400 References: <133a4c1d-d029-0bc2-d538-4e5c8e3dac1b@redhat.com> <20161010154625.14881-1-alex.bennee@linaro.org> From: Claudio Imbrenda Date: Tue, 11 Oct 2016 13:48:23 +0200 MIME-Version: 1.0 In-Reply-To: <20161010154625.14881-1-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Message-Id: <45b2441d-439c-26a2-d622-295b9d4d1666@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , pbonzini@redhat.com, borntraeger@de.ibm.com Cc: qemu-devel@nongnu.org, "open list:Overall" Tested-by: Claudio Imbrenda On 10/10/16 17:46, Alex Benn=C3=A9e wrote: > The changes to run_on_cpu and friends mean that all helpers are passed > the CPUState of vCPU they are running on. The conversion missed the > field in commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 which > introduced bugs. >=20 > Reported-by: Claudio Imbrenda > Signed-off-by: Alex Benn=C3=A9e > --- > kvm-all.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/kvm-all.c b/kvm-all.c > index efb5fe3..3dcce16 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -2215,15 +2215,14 @@ int kvm_sw_breakpoints_active(CPUState *cpu) >=20 > struct kvm_set_guest_debug_data { > struct kvm_guest_debug dbg; > - CPUState *cpu; > int err; > }; >=20 > -static void kvm_invoke_set_guest_debug(CPUState *unused_cpu, void *dat= a) > +static void kvm_invoke_set_guest_debug(CPUState *cpu, void *data) > { > struct kvm_set_guest_debug_data *dbg_data =3D data; >=20 > - dbg_data->err =3D kvm_vcpu_ioctl(dbg_data->cpu, KVM_SET_GUEST_DEBU= G, > + dbg_data->err =3D kvm_vcpu_ioctl(cpu, KVM_SET_GUEST_DEBUG, > &dbg_data->dbg); > } >=20