From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>
Cc: Sven Schnelle <svens@stackframe.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 6/7] hw/display/artist: Fix artist screen resolution
Date: Wed, 2 Sep 2020 15:09:57 -0700 [thread overview]
Message-ID: <45bf91fd-4e7f-7379-18a2-cdada67a3f6d@linaro.org> (raw)
In-Reply-To: <20200902214819.GA2424@ls3530.fritz.box>
On 9/2/20 2:48 PM, Helge Deller wrote:
>> Is it a bug that these Y were using 0x3ff and not 0x7ff?
>> Because it's pretty consistent...
>
> I'm not sure if was intentional, a bug or just initial coding by Sven.
> The old code was limiting to 1024 lines.
> I assume that there doesn't exist any real hardware with > 1024 lines,
> so it's more theoretical.
> I tested the code, and it seems to work with > 1024 at least.
> So, I think to use 0x7ff is probably more correct - at least if we
> allow more lines.
>
>> You should make that a separate change, for sure.
>
> I'd prefer to keep it in one patch.
> It's simply moving code around and reuse a macro.
It's more than that, it's a behaviour change.
Code refactoring should be separate from feature changes, when at all possible.
And here, its certainly possible.
>> Was the original values chosen by the user?
>
> Yes, can bet set by user via
> -global -global artist.width=800 -global artist.height=600
>
>> Should we be giving some sort of error for out-of-range values?
>
> I had a warning there, but then removed it again. Most users will
> probably use the default values anyway. If you really want, I will add a
> warning. I'm not a fan of errors. Errors usually abort, but we can
> adjust and simply continue here.
It's exactly the same error as -smp 1234, when only 8 cpus are supported. An
error is more than appropriate.
r~
next prev parent reply other threads:[~2020-09-02 22:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 18:34 [PATCH 0/7] hppa power button support, graphics updates and firmware fixes Helge Deller
2020-09-01 18:34 ` [PATCH 1/7] seabios-hppa: Update SeaBIOS to hppa-qemu-5.2-2 tag Helge Deller
2020-09-01 18:34 ` [PATCH 2/7] hw/hppa: Make number of TLB and BTLB entries configurable Helge Deller
2020-09-01 21:36 ` Richard Henderson
2020-09-02 11:16 ` Helge Deller
2020-09-02 16:52 ` Richard Henderson
2020-09-02 19:36 ` Helge Deller
2020-09-01 18:34 ` [PATCH 3/7] hw/hppa: Store boot device in fw_cfg section Helge Deller
2020-09-01 21:37 ` Richard Henderson
2020-09-01 18:34 ` [PATCH 4/7] hw/hppa: Inform SeaBIOS about fw_cfg port address Helge Deller
2020-09-01 21:39 ` Richard Henderson
2020-09-02 11:24 ` Helge Deller
2020-09-02 16:46 ` Richard Henderson
2020-09-02 19:37 ` Helge Deller
2020-09-01 18:34 ` [PATCH 5/7] hw/hppa: Add power button emulation Helge Deller
2020-09-01 21:42 ` Richard Henderson
2020-09-01 18:34 ` [PATCH 6/7] hw/display/artist: Fix artist screen resolution Helge Deller
2020-09-01 21:49 ` Richard Henderson
2020-09-02 21:48 ` Helge Deller
2020-09-02 22:09 ` Richard Henderson [this message]
2020-09-03 6:07 ` Helge Deller
2020-09-03 6:08 ` Helge Deller
2020-09-03 6:09 ` Helge Deller
2020-09-03 15:09 ` Richard Henderson
2020-09-01 18:34 ` [PATCH 7/7] target/hppa: Fix boot with old Linux installation CDs Helge Deller
2020-09-01 19:37 ` [PATCH 0/7] hppa power button support, graphics updates and firmware fixes Philippe Mathieu-Daudé
2020-09-01 19:49 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45bf91fd-4e7f-7379-18a2-cdada67a3f6d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).