From: Paolo Bonzini <pbonzini@redhat.com>
To: Jon Doron <arilou@gmail.com>, qemu-devel@nongnu.org
Cc: vkuznets@redhat.com
Subject: Re: [PATCH v2 1/4] hyperv: SControl is optional to enable SynIc
Date: Tue, 15 Mar 2022 12:29:50 +0100 [thread overview]
Message-ID: <45bfbd51-7da1-e617-60e6-3584b3485a43@redhat.com> (raw)
In-Reply-To: <20220216102500.692781-2-arilou@gmail.com>
On 2/16/22 11:24, Jon Doron wrote:
> + qemu_mutex_lock(&synic->sint_routes_mutex);
> + QLIST_INSERT_HEAD_RCU(&synic->sint_routes, sint_route, link);
> + qemu_mutex_unlock(&synic->sint_routes_mutex);
Hi,
I don't see any access to sint_routes outside hyperv_sint_route_new and
hyperv_sint_route_unref. Am I missing something or is this just for
debugging? If so, using the _RCU functions is not necessary.
Otherwise everything looks good, thanks!
Paolo
next prev parent reply other threads:[~2022-03-15 11:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 10:24 [PATCH v2 0/4] HyperV: Synthetic Debugging device Jon Doron
2022-02-16 10:24 ` [PATCH v2 1/4] hyperv: SControl is optional to enable SynIc Jon Doron
2022-02-24 16:36 ` Emanuele Giuseppe Esposito
2022-03-07 6:37 ` Jon Doron
2022-03-15 11:29 ` Paolo Bonzini [this message]
2022-02-16 10:24 ` [PATCH v2 2/4] hyperv: Add definitions for syndbg Jon Doron
2022-02-24 16:36 ` Emanuele Giuseppe Esposito
2022-02-16 10:24 ` [PATCH v2 3/4] hyperv: Add support to process syndbg commands Jon Doron
2022-02-24 16:36 ` Emanuele Giuseppe Esposito
2022-02-16 10:25 ` [PATCH v2 4/4] hw: hyperv: Initial commit for Synthetic Debugging device Jon Doron
2022-02-24 2:51 ` Jon Doron
2022-02-24 16:36 ` Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45bfbd51-7da1-e617-60e6-3584b3485a43@redhat.com \
--to=pbonzini@redhat.com \
--cc=arilou@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).