From: Jason Wang <jasowang@redhat.com>
To: Wei Xu <wexu@redhat.com>
Cc: maxime.coquelin@redhat.com, jfreimann@redhat.com,
qemu-devel@nongnu.org, tiwei.bie@intel.com
Subject: Re: [Qemu-devel] [[RFC v3 03/12] virtio: init memory cache for packed ring
Date: Mon, 15 Oct 2018 15:54:08 +0800 [thread overview]
Message-ID: <45cdc553-3ad6-e093-007b-4891c598fbab@redhat.com> (raw)
In-Reply-To: <20181015070954.GB27871@wei-ubt>
On 2018年10月15日 15:09, Wei Xu wrote:
>>> -hwaddr virtio_queue_get_avail_size(VirtIODevice *vdev, int n)
>>> +hwaddr virtio_queue_get_driver_size(VirtIODevice *vdev, int n)
>>> {
>>> - return offsetof(VRingAvail, ring) +
>>> - sizeof(uint16_t) * vdev->vq[n].vring.num;
>>> + int s;
>>> +
>>> + if (virtio_vdev_has_feature(vdev, VIRTIO_F_RING_PACKED)) {
>>> + return sizeof(struct VRingPackedDescEvent);
>>> + } else {
>>> + s = virtio_vdev_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX) ? 2 : 0;
>>> + return offsetof(VRingAvail, ring) +
>>> + sizeof(uint16_t) * vdev->vq[n].vring.num + s;
>> I tend to move this to an independent patch.
> You mean this two functions?
>
> Wei
>
I mean moving the adding of event to get_avail()/get_used().
Thanks
next prev parent reply other threads:[~2018-10-15 7:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 14:08 [Qemu-devel] [RFC v3 00/12] packed ring virtio-net userspace backend support wexu
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 01/12] virtio: introduce packed ring definitions wexu
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 02/12] virtio: redefine structure & memory cache for packed ring wexu
2018-10-15 3:03 ` Jason Wang
2018-10-15 7:26 ` Wei Xu
2018-10-15 8:03 ` Jason Wang
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 03/12] virtio: init " wexu
2018-10-15 3:10 ` Jason Wang
2018-10-15 7:09 ` Wei Xu
2018-10-15 7:54 ` Jason Wang [this message]
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 04/12] virtio: init wrap counter " wexu
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 05/12] virtio: init and desc empty check " wexu
2018-10-15 3:18 ` Jason Wang
2018-10-15 7:04 ` Wei Xu
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 06/12] virtio: get avail bytes " wexu
2018-10-15 3:47 ` Jason Wang
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 07/12] virtio: fill/flush/pop " wexu
2018-10-15 6:14 ` Jason Wang
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 08/12] virtio: event suppression support " wexu
2018-10-15 6:55 ` Jason Wang
2018-10-15 6:59 ` Jason Wang
2018-10-15 8:20 ` Wei Xu
2018-10-15 9:11 ` Jason Wang
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 09/12] virtio-net: fill head desc after done all in a chain wexu
2018-10-15 7:45 ` Jason Wang
2018-10-15 8:03 ` Wei Xu
2018-10-15 8:05 ` Jason Wang
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 10/12] virtio: packed ring feature bit for userspace backend wexu
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 11/12] virtio: enable packed ring via a new command line wexu
2018-10-11 14:08 ` [Qemu-devel] [[RFC v3 12/12] virtio: feature vhost-net support for packed ring wexu
2018-10-15 7:50 ` Jason Wang
2018-10-15 8:11 ` Wei Xu
2018-11-21 13:03 ` Maxime Coquelin
2018-11-22 3:46 ` Wei Xu
2018-11-21 14:39 ` [Qemu-devel] [RFC v3 00/12] packed ring virtio-net userspace backend support Tiwei Bie
2018-11-22 3:43 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45cdc553-3ad6-e093-007b-4891c598fbab@redhat.com \
--to=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tiwei.bie@intel.com \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).