From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C6E1C433E6 for ; Mon, 31 Aug 2020 21:16:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECC2C20693 for ; Mon, 31 Aug 2020 21:16:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CLNxAAe+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECC2C20693 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCr9q-0007KI-1Y for qemu-devel@archiver.kernel.org; Mon, 31 Aug 2020 17:16:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCr8I-0005ml-8S for qemu-devel@nongnu.org; Mon, 31 Aug 2020 17:14:30 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:37102) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCr8G-0000pn-DI for qemu-devel@nongnu.org; Mon, 31 Aug 2020 17:14:29 -0400 Received: by mail-pg1-x541.google.com with SMTP id 5so1409424pgl.4 for ; Mon, 31 Aug 2020 14:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=22ecnwz+xQW3jC3RmGUWnbBUJnB+yHXpUAC3wkYPOZM=; b=CLNxAAe+WaENWsLmNvra+PCKEJZZf6eskpqFY0XUytZPyrwF+gwAoBmmROdwcAwA0V K6DRuLe1WLT+w6qRdoAmu9xXNBGEA+/op1R6Q5cQfCMk2jMMvLW/uJaaZvnQG4HHGWHH 5KBlGPcTzODDiwfvc5hMN6blYqmAhi3mGieoRhSzDILvb2ZxGMo6t9n9lyntTJcPF2hv 5hUB4KSxIN2+pVXvEIm+3yIEYnHvtM8XnX4JpbksTmOy/mAApJsEuDGPxfYgtI8a4uq/ aGb0NwFLUC1T2jANlvuz94ZxxPa1Q7rCeVXwDPuTFjGIx2/H4n+w8gfD6WIgME8RqXR1 bIEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=22ecnwz+xQW3jC3RmGUWnbBUJnB+yHXpUAC3wkYPOZM=; b=G8c2LanH8XnoOoMgJ8Le7T+YRo7sIOzAeWWxIeKXsR52JmHgYutE6pXWVJz1aWOkDo X4cp/IpDYkzYxz6o4THrSETW39CH19xfHhnL0NZnKTxWsynPjqjuH+UhCZeVjoir5HSg E83cmtUCvp9TJsjB1P/XfCvj1BEOft3wSSuUU4UY5Ffu52dUZpIsqw0F8XOqvY8tvTMF IVwOadLMGpHEhbth1ip9yTcGNUBVjUe3fLga177oyTYrhWojzJAxmEFW0NvXrBTYFzYu eywe6q/VZpTdmyVBu1fBMjwjaKA54dQzcQVmr2UEyLsD8VM5fu3s52HjWC3eReWEUujb Oh1w== X-Gm-Message-State: AOAM530aXL108ncg5Tkj4eFMZm8JfEvjRYN+R+943thCb0GIryUpJ58U rKZGD8+SPlIgMyo7sdwXQMUnig== X-Google-Smtp-Source: ABdhPJxFuPR+29HZdaPJx2lHNbrzWzLlBqAb9kdsGjblmeTNHekGacpovLmbUh/crggwrgUfOdrouQ== X-Received: by 2002:a63:4923:: with SMTP id w35mr1200787pga.368.1598908465353; Mon, 31 Aug 2020 14:14:25 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id l145sm9590077pfd.45.2020.08.31.14.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2020 14:14:24 -0700 (PDT) Subject: Re: [PATCH v2 1/7] target: rename all *_do_interupt functions to _do_interrupt_locked To: Robert Foley , qemu-devel@nongnu.org References: <20200819182856.4893-1-robert.foley@linaro.org> <20200819182856.4893-2-robert.foley@linaro.org> From: Richard Henderson Message-ID: <45ce8b56-a00d-9504-7eeb-e4cce4efed31@linaro.org> Date: Mon, 31 Aug 2020 14:14:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200819182856.4893-2-robert.foley@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::541; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x541.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.13, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sarah Harris , Chris Wulff , Sagar Karandikar , David Hildenbrand , Anthony Green , Mark Cave-Ayland , Aleksandar Rikalo , Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , "open list:Overall KVM CPUs" , Yoshinori Sato , Aleksandar Markovic , Palmer Dabbelt , David Gibson , Artyom Tarasenko , Thomas Huth , Eduardo Habkost , "open list:S390 general arch..." , "open list:ARM TCG CPUs" , Michael Rolnik , peter.puhov@linaro.org, Stafford Horne , alex.bennee@linaro.org, Richard Henderson , "open list:RISC-V TCG CPUs" , Bastian Koppelmann , Cornelia Huck , Laurent Vivier , Michael Walle , "open list:sPAPR" , pbonzini@redhat.com, Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/19/20 11:28 AM, Robert Foley wrote: > The rename of all *_do_interrupt functions to *_do_interrupt_locked > is preparation for pushing the BQL lock around these functions > down into the per-arch implementation of *_do_interrupt. > In a later patch which pushes down the lock, we will add > a new *_do_interrupt function which grabs the BQL and calls to > *_do_interrupt_locked. > > This is the first patch in a series of transitions to move the > BQL down into the do_interrupt per arch function. This set of > transitions is needed to maintain bisectability. > > The purpose of this set of changes is to set the groundwork > so that an arch could move towards removing > the BQL from the cpu_handle_interrupt/exception paths. > > This approach was suggested by Paolo Bonzini. > For reference, here are key posts in the discussion, explaining > the reasoning/benefits of this approach. > > https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00784.html > https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg01517.html > https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08731.html > https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg00044.html > > Signed-off-by: Robert Foley > --- Reviewed-by: Richard Henderson r~