* [PATCH] target/m68k: Remove unused @cpu_exception_index TCGv
@ 2025-09-24 17:13 Philippe Mathieu-Daudé
2025-09-24 17:24 ` Richard Henderson
2025-10-07 8:19 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-09-24 17:13 UTC (permalink / raw)
To: qemu-devel
Cc: Anton Johansson, Pierrick Bouvier, Laurent Vivier,
Philippe Mathieu-Daudé
When moving the @exception_index from each target ArchCPU
to the global CPUState in commit 27103424c40 ("cpu: Move
exception_index field from CPU_COMMON to CPUState"), the
@cpu_exception_index TCGv has been created for m68k target.
For years, no code ever used this register. Simply remove it.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/m68k/translate.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 97afceb1297..0cee54f4900 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -45,7 +45,6 @@
#undef DEFO64
static TCGv_i32 cpu_halted;
-static TCGv_i32 cpu_exception_index;
static char cpu_reg_names[2 * 8 * 3 + 5 * 4];
static TCGv cpu_dregs[8];
@@ -81,11 +80,6 @@ void m68k_tcg_init(void)
cpu_halted = tcg_global_mem_new_i32(tcg_env,
-offsetof(M68kCPU, env) +
offsetof(CPUState, halted), "HALTED");
- cpu_exception_index = tcg_global_mem_new_i32(tcg_env,
- -offsetof(M68kCPU, env) +
- offsetof(CPUState, exception_index),
- "EXCEPTION");
-
p = cpu_reg_names;
for (i = 0; i < 8; i++) {
sprintf(p, "D%d", i);
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/m68k: Remove unused @cpu_exception_index TCGv
2025-09-24 17:13 [PATCH] target/m68k: Remove unused @cpu_exception_index TCGv Philippe Mathieu-Daudé
@ 2025-09-24 17:24 ` Richard Henderson
2025-10-07 8:19 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2025-09-24 17:24 UTC (permalink / raw)
To: qemu-devel
On 9/24/25 10:13, Philippe Mathieu-Daudé wrote:
> When moving the @exception_index from each target ArchCPU
> to the global CPUState in commit 27103424c40 ("cpu: Move
> exception_index field from CPU_COMMON to CPUState"), the
> @cpu_exception_index TCGv has been created for m68k target.
>
> For years, no code ever used this register. Simply remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/m68k/translate.c | 6 ------
> 1 file changed, 6 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index 97afceb1297..0cee54f4900 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -45,7 +45,6 @@
> #undef DEFO64
>
> static TCGv_i32 cpu_halted;
> -static TCGv_i32 cpu_exception_index;
>
> static char cpu_reg_names[2 * 8 * 3 + 5 * 4];
> static TCGv cpu_dregs[8];
> @@ -81,11 +80,6 @@ void m68k_tcg_init(void)
> cpu_halted = tcg_global_mem_new_i32(tcg_env,
> -offsetof(M68kCPU, env) +
> offsetof(CPUState, halted), "HALTED");
> - cpu_exception_index = tcg_global_mem_new_i32(tcg_env,
> - -offsetof(M68kCPU, env) +
> - offsetof(CPUState, exception_index),
> - "EXCEPTION");
> -
> p = cpu_reg_names;
> for (i = 0; i < 8; i++) {
> sprintf(p, "D%d", i);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/m68k: Remove unused @cpu_exception_index TCGv
2025-09-24 17:13 [PATCH] target/m68k: Remove unused @cpu_exception_index TCGv Philippe Mathieu-Daudé
2025-09-24 17:24 ` Richard Henderson
@ 2025-10-07 8:19 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-10-07 8:19 UTC (permalink / raw)
To: qemu-devel; +Cc: Anton Johansson, Pierrick Bouvier, Laurent Vivier
On 24/9/25 19:13, Philippe Mathieu-Daudé wrote:
> When moving the @exception_index from each target ArchCPU
> to the global CPUState in commit 27103424c40 ("cpu: Move
> exception_index field from CPU_COMMON to CPUState"), the
> @cpu_exception_index TCGv has been created for m68k target.
>
> For years, no code ever used this register. Simply remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/m68k/translate.c | 6 ------
> 1 file changed, 6 deletions(-)
Patch queued, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-07 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-24 17:13 [PATCH] target/m68k: Remove unused @cpu_exception_index TCGv Philippe Mathieu-Daudé
2025-09-24 17:24 ` Richard Henderson
2025-10-07 8:19 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).