From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFDAC433DB for ; Thu, 28 Jan 2021 08:45:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E20B864DD1 for ; Thu, 28 Jan 2021 08:45:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E20B864DD1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l52vP-0002j7-Dm for qemu-devel@archiver.kernel.org; Thu, 28 Jan 2021 03:45:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l52u9-0001bl-GG for qemu-devel@nongnu.org; Thu, 28 Jan 2021 03:43:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:43374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l52u3-0003OM-Rp for qemu-devel@nongnu.org; Thu, 28 Jan 2021 03:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611823426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D/e7TnOWmxRXxLy/nsQzHLpX6QnNr8wx+NoXtTK+n7A=; b=Su6AgwQwCh7Mc6Gh+mKXmf9K1llaEuoC8aR2116v/hz7lHYJCjeBP6lugm87G+0JUqi3jY Jae6DTH25U4GJMk7nTOixmqcOaxSAhCT4hinGdUOibkwtwwA2X19dt5TvBMeQY6N5bb2ey FkqUeYLgpYg+MlgakIWJ48exdMAh+W4= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-516-m3UAJ_E0MuiSd1V9Z1d7jg-1; Thu, 28 Jan 2021 03:43:44 -0500 X-MC-Unique: m3UAJ_E0MuiSd1V9Z1d7jg-1 Received: by mail-ej1-f72.google.com with SMTP id h18so1870791ejx.17 for ; Thu, 28 Jan 2021 00:43:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D/e7TnOWmxRXxLy/nsQzHLpX6QnNr8wx+NoXtTK+n7A=; b=ZY4VXrAczNrb2kXhnOxOHaH0NOF1bE9VZ/ZvGLa/58aUuuAlsOrg/etuKdQnlN4j0u YwGdXqoTM+XoUhvddd2pDOGd5hcV/ZK3QFZ/KUcd5uD3/WoailjdwgdXxwKnFfW7PuWY tSbsUAdy53QGnBi2l86ZLpKWz2V5wyco5cLc8j7UY5mMofrSK98nY17Jg9Y9jQXJhCPU nq+45p9efVZL+v9bJVB5Sx7pUCJ8HE0q8kGxecpBZk7N4FvH9EBjjIzg+paKak0Eq1GM 18E6z91tbxpQLDFIwUrYGAySVfP+ycy9Gmoacz2ZZMepCbjZWPf7ywsBbdZl4kQmlnte QoGg== X-Gm-Message-State: AOAM533WY4AW4dQ1vKUQTl2TfwEy3Twafli/qvQbjU7LxZNs7o6r+rsi 6uA6E9QhDHVf13g0qOzZuNCMuRgpTNAB0idEeHLaBCCNAhBAFYkiG5Pknzmg302LR7Vb5A9lBaF 7EQcz4DtosUjN56U= X-Received: by 2002:a17:906:9497:: with SMTP id t23mr10336944ejx.523.1611823423326; Thu, 28 Jan 2021 00:43:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKbrZ6MMDSlL/JWJZri8Wo0IadrGtZkVbXLuKUMuoh4ENmW+J4VwnilA9gRJs79AC69pQMMQ== X-Received: by 2002:a17:906:9497:: with SMTP id t23mr10336934ejx.523.1611823423135; Thu, 28 Jan 2021 00:43:43 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id f13sm1959356ejf.42.2021.01.28.00.43.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 00:43:42 -0800 (PST) Subject: Re: [PATCH] target/i386: Fix decoding of certain BMI instructions To: David Greenaway , qemu-devel@nongnu.org References: <20210114063958.1508050-1-dgreenaway@google.com> From: Paolo Bonzini Message-ID: <45fa6907-c652-c159-4b29-10b1ec12d8bb@redhat.com> Date: Thu, 28 Jan 2021 09:43:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.308, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 27/01/21 23:54, David Greenaway wrote: > On 14 Jan 2021, David Greenaway wrote: >> This patch fixes a translation bug for a subset of x86 BMI instructions >> such as the following: [...] > > Gentle ping. > > The patch is up at: > > https://patchwork.kernel.org/project/qemu-devel/patch/20210114063958.1508050-1-dgreenaway@google.com/ > > if that helps. > > Cheers, > David > Hi, I didn't have time to write a test yet (for tests/tcg). I'll take a look now. Paolo