From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] please review smc91c111 network bug fix
Date: Sun, 25 Mar 2007 16:56:59 +0200 [thread overview]
Message-ID: <46068DBB.6050500@aurel32.net> (raw)
In-Reply-To: <a20f395e0703241136i30e931afw6519c20e6750b0c1@mail.gmail.com>
Wang Cheng Yeh a écrit :
> address mapping error and cause arm versatile unstable.
>
This patches looks ok to me, at least it corresponds to what the
datasheet says. I am using it for a few hours, I have seen no regression
so far.
>
> Index: hw/smc91c111.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/smc91c111.c,v
> retrieving revision 1.5
> diff -u -r1.5 smc91c111.c
> --- hw/smc91c111.c 21 Dec 2006 17:23:49 -0000 1.5
> +++ hw/smc91c111.c 24 Mar 2007 18:15:21 -0000
> @@ -446,7 +446,9 @@
> case 7:
> /* Not implemented. */
> return 0;
> - case 8: /* Free memory available. */
> + case 8: /* Memory size. */
> + return NUM_PACKETS;
> + case 9: /* Free memory available. */
> {
> int i;
> int n;
> @@ -457,8 +459,6 @@
> }
> return n;
> }
> - case 9: /* Memory size. */
> - return NUM_PACKETS;
> case 10: case 11: /* RPCR */
> /* Not implemented. */
> return 0;
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
prev parent reply other threads:[~2007-03-25 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-24 18:36 [Qemu-devel] please review smc91c111 network bug fix Wang Cheng Yeh
2007-03-25 14:56 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46068DBB.6050500@aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).