From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HVUCN-0007v3-J0 for qemu-devel@nongnu.org; Sun, 25 Mar 2007 10:59:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HVUCJ-0007u6-2Z for qemu-devel@nongnu.org; Sun, 25 Mar 2007 10:59:59 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HVUCI-0007u3-VM for qemu-devel@nongnu.org; Sun, 25 Mar 2007 09:59:55 -0500 Received: from farad.aurel32.net ([82.232.2.251] helo=mail.aurel32.net) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HVUA5-0002uU-E8 for qemu-devel@nongnu.org; Sun, 25 Mar 2007 10:57:41 -0400 Received: from [2001:618:400:fc13:740d:85ff:fef2:5037] (helo=volta.aurel32.net) by mail.aurel32.net with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1HVU9U-0005t4-2u for qemu-devel@nongnu.org; Sun, 25 Mar 2007 16:57:00 +0200 Received: from localhost ([127.0.0.1] ident=aurel32) by volta.aurel32.net with esmtp (Exim 4.63) (envelope-from ) id 1HVU9T-0001M0-Ur for qemu-devel@nongnu.org; Sun, 25 Mar 2007 16:56:59 +0200 Message-ID: <46068DBB.6050500@aurel32.net> Date: Sun, 25 Mar 2007 16:56:59 +0200 From: Aurelien Jarno MIME-Version: 1.0 Subject: Re: [Qemu-devel] please review smc91c111 network bug fix References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Wang Cheng Yeh a écrit : > address mapping error and cause arm versatile unstable. > This patches looks ok to me, at least it corresponds to what the datasheet says. I am using it for a few hours, I have seen no regression so far. > > Index: hw/smc91c111.c > =================================================================== > RCS file: /sources/qemu/qemu/hw/smc91c111.c,v > retrieving revision 1.5 > diff -u -r1.5 smc91c111.c > --- hw/smc91c111.c 21 Dec 2006 17:23:49 -0000 1.5 > +++ hw/smc91c111.c 24 Mar 2007 18:15:21 -0000 > @@ -446,7 +446,9 @@ > case 7: > /* Not implemented. */ > return 0; > - case 8: /* Free memory available. */ > + case 8: /* Memory size. */ > + return NUM_PACKETS; > + case 9: /* Free memory available. */ > { > int i; > int n; > @@ -457,8 +459,6 @@ > } > return n; > } > - case 9: /* Memory size. */ > - return NUM_PACKETS; > case 10: case 11: /* RPCR */ > /* Not implemented. */ > return 0; > > > ------------------------------------------------------------------------ > > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net