From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: carlos@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH] Implement Win32 locking in vl.c (create_pidfile).
Date: Sun, 25 Mar 2007 12:58:01 -0500 [thread overview]
Message-ID: <4606B829.90800@codemonkey.ws> (raw)
In-Reply-To: <20070323231014.GR26700@lios>
Carlos O'Donell wrote:
> The following patch implements Win32 locking for vl.c (create_pidfile).
> Builds for mingw32, and tested on a Windows Server 2003 host by running
> two qemu's with the same -pidfile option.
>
> When cross-compiling the use of --enable-mingw32 should effect AIOLIBS,
> otherwise the build will use "-lrt" and this is not valid when compiling
> with mingw32.
>
Instead of using an #ifdef, I think it would be better to have a win32
specific file and a unix specific file that compiles conditionally
depending on the host.
Sort of like and osdep-posix.c and and osdep-win32.c. Both would
implement a create_pidfile() function. I think this general approach
would help clean up a lot of the win32 code.
Thoughts?
Regards,
Anthony Liguori
> Patch attached for both. Built on linux and tested on Windows Server
> 2003.
>
> Comments? Please include me in the CC.
>
> Cheers,
> Carlos.
>
next prev parent reply other threads:[~2007-03-25 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 23:10 [Qemu-devel] [PATCH] Implement Win32 locking in vl.c (create_pidfile) Carlos O'Donell
2007-03-25 17:58 ` Anthony Liguori [this message]
2007-03-25 21:35 ` Thiemo Seufer
2007-03-25 23:30 ` Thiemo Seufer
2007-03-27 13:22 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4606B829.90800@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=carlos@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).