From: Paolo Bonzini <pbonzini@redhat.com>
To: "Zhang, Chen" <chen.zhang@intel.com>,
"Jason Wang" <jasowang@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-dev <qemu-devel@nongnu.org>,
"Eric Blake" <eblake@redhat.com>,
"libvir-list@redhat.com" <libvir-list@redhat.com>
Cc: Zhang Chen <zhangckid@gmail.com>
Subject: Re: [PATCH V4 0/5] Introduce Advanced Watch Dog module
Date: Thu, 12 Mar 2020 16:52:15 +0100 [thread overview]
Message-ID: <460ee5fb-fd36-0da3-0f81-22d9be12814b@redhat.com> (raw)
In-Reply-To: <c16e2cda-a498-4913-2811-6c6ea6b0b0df@intel.com>
On 09/03/20 10:32, Zhang, Chen wrote:
> 4. Implementation issue.
>
> The AWD script as an optional feature is OK for me.
>
> And report the triggering of the watchdog via QMP events is enough for
> current usage.
>
> But it looks have limitation to notify outside Qemu. I don't know which
> is better choice.
>
> If the QMP events solution is better, I will fix it in next version.
Good, thanks.
Naming-wise, it's ugly that we already have a WATCHDOG event for guest
watchdog devices. The following design however should allow setting up
multiple watchdogs
- Creating a watchdog from the command line:
-object watchdog,id=STR,timeout=NNN,chardev=CHR
and object_add/object-add can also be used for HMP and QMP.
- Reporting a watchdog timeout via QMP:
{ 'event': 'WATCHDOG_TIMEOUT',
'data': { 'id': 'str' } }
- Protocol: the data sent on the chardev to QEMU must be
WATCHDOG=1
optionally followed by exactly one \n character. All other data is ignored.
Paolo
prev parent reply other threads:[~2020-03-12 15:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 12:45 [PATCH V4 0/5] Introduce Advanced Watch Dog module Zhang Chen
2019-12-17 12:45 ` [PATCH V4 1/5] net/awd.c: Introduce Advanced Watch Dog module framework Zhang Chen
2019-12-17 12:45 ` [PATCH V4 2/5] net/awd.c: Initailize input/output chardev Zhang Chen
2019-12-17 12:45 ` [PATCH V4 3/5] net/awd.c: Load advanced watch dog worker thread job Zhang Chen
2019-12-17 12:45 ` [PATCH V4 4/5] vl.c: Make Advanced Watch Dog delayed initialization Zhang Chen
2019-12-17 12:45 ` [PATCH V4 5/5] docs/awd.txt: Add doc to introduce Advanced WatchDog(AWD) module Zhang Chen
2020-01-07 4:32 ` [PATCH V4 0/5] Introduce Advanced Watch Dog module Zhang, Chen
2020-01-19 9:10 ` Zhang, Chen
2020-01-20 2:56 ` Jason Wang
2020-02-11 8:58 ` Zhang, Chen
2020-02-12 2:56 ` Jason Wang
2020-02-20 3:36 ` Zhang, Chen
2020-03-04 8:06 ` Zhang, Chen
2020-03-04 13:37 ` Paolo Bonzini
2020-03-09 9:32 ` Zhang, Chen
2020-03-12 15:52 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460ee5fb-fd36-0da3-0f81-22d9be12814b@redhat.com \
--to=pbonzini@redhat.com \
--cc=chen.zhang@intel.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=libvir-list@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).