qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>, "Iris Chen" <irischenlj@fb.com>
Cc: pdel@fb.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	patrick@stwcx.xyz, alistair@alistair23.me, kwolf@redhat.com,
	hreitz@redhat.com, peter.maydell@linaro.org, andrew@aj.id.au,
	joel@jms.id.au, lvivier@redhat.com, pbonzini@redhat.com,
	qemu-block@nongnu.org
Subject: Re: [PATCH v3] hw: m25p80: allow write_enable latch get/set
Date: Fri, 13 May 2022 16:37:01 +0200	[thread overview]
Message-ID: <4613a814-c858-1cac-3750-789b388cba8d@redhat.com> (raw)
In-Reply-To: <bfbffeef-e7d1-8003-24ca-4cafc90e60a4@kaod.org>

On 13/05/2022 15.54, Cédric Le Goater wrote:
> Thomas, and others,
> 
> Are you ok with the qtest extension proposed by Iris ?
> 
> If so, I can take them through an aspeed PR.

Fine for me!

> On 5/13/22 07:50, Iris Chen via wrote:
>> The write_enable latch property is not currently exposed.
>> This commit makes it a modifiable property.
>>
>> Signed-off-by: Iris Chen <irischenlj@fb.com>
>> ---
>> v3: Addressed comments by Peter and Cedric.
>> v2: Ran ./scripts/checkpatch.pl on the patch and added a description. 
>> Fixed comments regarding DEFINE_PROP_BOOL.

Acked-by: Thomas Huth <thuth@redhat.com>




  reply	other threads:[~2022-05-13 14:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <irischenlj@gmail.com>
2022-05-13  5:50 ` [PATCH v3] hw: m25p80: allow write_enable latch get/set Iris Chen via
2022-05-13 13:54   ` Cédric Le Goater
2022-05-13 14:37     ` Thomas Huth [this message]
2022-05-13 15:03       ` Cédric Le Goater
2022-05-13 22:47   ` Francisco Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4613a814-c858-1cac-3750-789b388cba8d@redhat.com \
    --to=thuth@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=andrew@aj.id.au \
    --cc=clg@kaod.org \
    --cc=hreitz@redhat.com \
    --cc=irischenlj@fb.com \
    --cc=joel@jms.id.au \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=patrick@stwcx.xyz \
    --cc=pbonzini@redhat.com \
    --cc=pdel@fb.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).