From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HaLIU-0007Ri-Vu for qemu-devel@nongnu.org; Sat, 07 Apr 2007 20:30:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HaLIT-0007PP-GQ for qemu-devel@nongnu.org; Sat, 07 Apr 2007 20:30:22 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HaLIT-0007PD-Ce for qemu-devel@nongnu.org; Sat, 07 Apr 2007 20:30:21 -0400 Received: from sp604003mt.neufgp.fr ([84.96.92.56] helo=smTp.neuf.fr) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HaLEo-0000UK-JB for qemu-devel@nongnu.org; Sat, 07 Apr 2007 20:26:34 -0400 Received: from [84.102.211.37] by sp604003mt.gpm.neuf.ld (Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006)) with ESMTP id <0JG5000S6IET2WY0@sp604003mt.gpm.neuf.ld> for qemu-devel@nongnu.org; Sun, 08 Apr 2007 01:25:42 +0200 (CEST) Date: Sun, 08 Apr 2007 01:26:03 +0200 From: Fabrice Bellard Subject: Re: [Qemu-devel] qemu Makefile.target vl.h hw/acpi.c hw/adlib.c ... In-reply-to: <200704072145.27203.paul@codesourcery.com> Message-id: <4618288B.5060201@bellard.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT References: <200704072010.05798.paul@codesourcery.com> <1175977726.1516.15.camel@rapid> <200704072145.27203.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, > I can only fix the code that I have access to. > > IMHO your request that I revert changes because they allegedly break code that > noone else has access to is unreasonable. My changes are a significant > cleanup to qemu internals. > > However if there is agreement from other maintainers I will revert my patch. I don't think you need to revert your patch. Personally, I would have changed the following: 1) The code is more generic than IRQs, it can be applied to any logic signal, so the naming should show it. 2) I don't like hiding pointers in types, so I would use for example 'QEMUSignal *' instead of 'qemu_irq'. Regarding the PPC problem, maybe you could just revert the patches in the MIPS and PowerPC CPUs structures, as I don't think it is necessary to move the IRQ code at this level now. BTW, I have a small PREP test image that I can publish. I am planning since some time to add to the QEMU web site an automatic regression testing system which will automatically launch many OSes with the current CVS version. I had no time to do it recently, but if no one does it before I'll try to complete it ! Regards, Fabrice.