[Qemu-devel] [Patch] Makefile.target

[Qemu-devel] [Patch] Makefile.target

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

This small patch for Makefile.target fixes a very special build issue:

make distclean # (only needed to remove files left from earlier builds)
./configure
make -C i386-softmmu # (or any other system emulation)

will try to build the missing dyngen and fail because dyngen is
normally build by the root Makefile.

The patch adds a rule for dyngen which simply calls "make dyngen" in the
root directory.

Stefan


[-- Attachment #2: Makefile.patch --]
[-- Type: text/x-diff, Size: 464 bytes --]

Index: Makefile.target
===================================================================
RCS file: /sources/qemu/qemu/Makefile.target,v
retrieving revision 1.160
diff -u -b -B -r1.160 Makefile.target
--- Makefile.target	11 Apr 2007 22:46:06 -0000	1.160
+++ Makefile.target	15 Apr 2007 12:26:55 -0000
@@ -540,6 +540,9 @@
 
 translate-op.o: translate-all.c op.h opc.h cpu.h
 
+$(DYNGEN):
+	make -C .. dyngen$(EXESUF)
+
 op.h: op.o $(DYNGEN)
 	$(DYNGEN) -o $@ $<
 

Re: [Qemu-devel] [Patch] Makefile.target

[Paul Brook]

On Sunday 15 April 2007 14:57, Stefan Weil wrote:
> This small patch for Makefile.target fixes a very special build issue:
>
> make distclean # (only needed to remove files left from earlier builds)
> ./configure
> make -C i386-softmmu # (or any other system emulation)
>
> will try to build the missing dyngen and fail because dyngen is
> normally build by the root Makefile.
>
> The patch adds a rule for dyngen which simply calls "make dyngen" in the
> root directory.

I think "don't do that" is the most appropriate response to this problem.
It's certainly not something I'd like to commit to keeping working long-term.

Try "make subdir-i386-softmmu" if you really must do this.
Configuring with --target-list=i386-softmmu is a much better solution though.

Paul

Re: [Qemu-devel] [Patch] Makefile.target

[Stefan Weil]

Hi Paul,

of course it is always good practice to avoid errors.

But nevertheless, sometimes it happens that I "do that",
and then I'm always happy when I get a clear error
message. Or even better, when something works as
expected even when I did something unexpected.
You are lucky if you never experienced such situations.

In my case, even a simple line like
$(DYNGEN):
in Makefile.target would have made me happier.

"make subdir-i386-softmmu" is ok for my application,
configuring with --target-list=i386-softmmu is no solution though
because I need mips-softmmu and mipsel-softmmu, too :-)

Stefan

Paul Brook schrieb:
> On Sunday 15 April 2007 14:57, Stefan Weil wrote:
>> This small patch for Makefile.target fixes a very special build issue:
>>
>> make distclean # (only needed to remove files left from earlier builds)
>> ./configure
>> make -C i386-softmmu # (or any other system emulation)
>>
>> will try to build the missing dyngen and fail because dyngen is
>> normally build by the root Makefile.
>>
>> The patch adds a rule for dyngen which simply calls "make dyngen" in the
>> root directory.
>
> I think "don't do that" is the most appropriate response to this problem.
> It's certainly not something I'd like to commit to keeping working
> long-term.
>
> Try "make subdir-i386-softmmu" if you really must do this.
> Configuring with --target-list=i386-softmmu is a much better solution
> though.
>
> Paul
>

Re: [Qemu-devel] [Patch] Makefile.target

[Paul Brook]

> But nevertheless, sometimes it happens that I "do that",
> and then I'm always happy when I get a clear error
> message. Or even better, when something works as
> expected even when I did something unexpected.
> You are lucky if you never experienced such situations.
>
> In my case, even a simple line like
> $(DYNGEN):
> in Makefile.target would have made me happier.

I still think you're poking around in things that shouldn't concern you, so 
deserve everything you get.

> "make subdir-i386-softmmu" is ok for my application,
> configuring with --target-list=i386-softmmu is no solution though
> because I need mips-softmmu and mipsel-softmmu, too :-)

So configure with --target-list=i386-softmmu,mips-softmmu,mipsel-softmmu

Paul