From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()
Date: Wed, 8 Nov 2017 16:47:07 +0100 [thread overview]
Message-ID: <462c8b69-9665-1342-fd01-5ba57049a39c@redhat.com> (raw)
In-Reply-To: <20171108154226.GC6118@stefanha-x1.localdomain>
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
On 08/11/2017 16:42, Stefan Hajnoczi wrote:
>> In any case, co_aio_sleep_ns()
>> + * does not affect the #AioContext where the current coroutine is running,
>> + * as the coroutine will restart on the same #AioContext that it is
>> + * running on.
> I cannot parse the second sentence. What does "affecting" an AioContext
> mean? Does "where the current coroutine is running" simply mean "the
> caller"?
>
> What is it trying to say? My guess is: the caller will be resumed in
> the current AioContext, not the timer's AioContext.
Yes, that is the intended meaning. Perhaps just s/current//.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-11-08 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 22:37 [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns() Eric Blake
2017-11-08 13:39 ` Marc-André Lureau
2017-11-08 15:42 ` Stefan Hajnoczi
2017-11-08 15:47 ` Paolo Bonzini [this message]
2017-11-08 15:57 ` Eric Blake
2017-11-08 17:36 ` Stefan Hajnoczi
2017-11-08 17:42 ` Eric Blake
2017-11-08 17:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462c8b69-9665-1342-fd01-5ba57049a39c@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).