Re: [Qemu-devel] [PATCH v5 13/13] iotests: Add test for NBD's blockdev-add interface

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

On 25.10.2016 16:41, Markus Armbruster wrote:
> Max Reitz <mreitz@redhat.com> writes:
> 
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>  tests/qemu-iotests/147     | 196 +++++++++++++++++++++++++++++++++++++++++++++
>>  tests/qemu-iotests/147.out |   5 ++
>>  tests/qemu-iotests/group   |   1 +
>>  3 files changed, 202 insertions(+)
>>  create mode 100755 tests/qemu-iotests/147
>>  create mode 100644 tests/qemu-iotests/147.out
>>
>> diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147
>> new file mode 100755
>> index 0000000..32d2a03
>> --- /dev/null
>> +++ b/tests/qemu-iotests/147
>> @@ -0,0 +1,196 @@
> [...]
>> +if __name__ == '__main__':
>> +    # Need to support image creation
>> +    iotests.main(supported_fmts=['vpc', 'parallels', 'qcow', 'vdi', 'qcow2',
>> +                                 'vmdk', 'raw', 'vhdx', 'qed'])
>> +
> 
> I just fed the series to git-am to make sure it still applies after me
> rewriting qapi-next a bit, and git-am is unhappy with you adding a
> trailing blank line.

Oops, sorry. Would fix in v6, but if this is the only issue with this
series (other than Eric's tab issue in patch 8), I'd like to leave this
to the maintainer.

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 480 bytes --]