From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>,
Nico Boehr <nrb@linux.ibm.com>,
qemu-devel@nongnu.org
Cc: linux-s390@vger.kernel.org, thuth@redhat.com,
richard.henderson@linaro.org
Subject: Re: [PATCH qemu v2] s390x: sck: load into a temporary not into in1
Date: Thu, 27 Jan 2022 11:45:13 +0100 [thread overview]
Message-ID: <463337d3-dad9-abbc-b0e3-544e08160234@redhat.com> (raw)
In-Reply-To: <a90563ea-2740-d4ca-d2f3-6b6861faf0de@linux.ibm.com>
On 27.01.22 11:32, Janosch Frank wrote:
> On 1/26/22 09:42, Nico Boehr wrote:
>> We previously loaded into in1, but in1 is not filled during
>> disassembly and hence always zero. This leads to an assertion failure:
>>
>> qemu-system-s390x: /home/nrb/qemu/include/tcg/tcg.h:654: temp_idx:
>> Assertion `n >= 0 && n < tcg_ctx->nb_temps' failed.`
>>
>> Instead, use in2_la2_m64a to load from storage into in2 and pass that to
>> the helper, which matches what we already do for SCKC.
>>
>> This fixes the SCK test I sent here under TCG:
>> <https://www.spinics.net/lists/kvm/msg265169.html>
>>
>> Suggested-by: David Hildenbrand <david@redhat.com>
>> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
>
> @David: Was this already broken when it was implemented?
> I.e. do we want a "Fixes: 9dc67537 ("s390x/tcg: implement SET CLOCK ")" tag?
That sounds about right.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-01-27 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 8:42 [PATCH qemu v2] s390x: sck: load into a temporary not into in1 Nico Boehr
2022-01-26 8:46 ` David Hildenbrand
2022-01-27 10:32 ` Janosch Frank
2022-01-27 10:45 ` David Hildenbrand [this message]
2022-01-28 10:01 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=463337d3-dad9-abbc-b0e3-544e08160234@redhat.com \
--to=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).